Skip to content

Conversation

@GSVarsha
Copy link
Contributor

Sanic: capture responseHeadersOnEntrySpans

Signed-off-by: Varsha GS varsha.gs@ibm.com

@GSVarsha GSVarsha self-assigned this Feb 14, 2024
@GSVarsha GSVarsha force-pushed the capture_header_sanic branch from f557fe7 to f913157 Compare February 14, 2024 14:38
@GSVarsha GSVarsha added the WIP work in progress label Feb 14, 2024
@GSVarsha GSVarsha marked this pull request as draft February 15, 2024 08:19
@GSVarsha GSVarsha force-pushed the capture_header_sanic branch from f913157 to 53eebdb Compare February 15, 2024 09:25
@GSVarsha GSVarsha marked this pull request as ready for review February 15, 2024 09:26
@GSVarsha GSVarsha removed the WIP work in progress label Feb 15, 2024
@GSVarsha GSVarsha requested a review from pvital February 15, 2024 09:48
@GSVarsha GSVarsha requested a review from Ferenc- February 15, 2024 09:50
@GSVarsha GSVarsha added the do NOT merge Depends on another PR or WIP label Feb 15, 2024
Copy link
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

Signed-off-by: Varsha GS <varsha.gs@ibm.com>
@GSVarsha GSVarsha force-pushed the capture_header_sanic branch from 53eebdb to e835c00 Compare February 15, 2024 10:30
@GSVarsha GSVarsha removed the do NOT merge Depends on another PR or WIP label Feb 15, 2024
Copy link
Member

@Ferenc- Ferenc- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@GSVarsha GSVarsha merged commit f393063 into master Feb 18, 2024
@GSVarsha GSVarsha deleted the capture_header_sanic branch February 18, 2024 10:11
@GSVarsha GSVarsha added this to the H1-2024 milestone Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants