fix(test_boto3) :Remove explicit credential mocking #500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
GSVarsha
commented
Feb 7, 2024
GSVarsha
commented
- Remove explicit credential mocking
- Minor variable name fixes
- minor variable name fixes Signed-off-by: Varsha GS <varsha.gs@ibm.com>
Ferenc-
approved these changes
Feb 7, 2024
Member
Ferenc-
left a comment
Ferenc-
left a comment
There was a problem hiding this comment.
The explicit credential mocking is still the recommended action by the documentation: https://docs.getmoto.org/en/latest/docs/getting_started.html#recommended-usage
But by now I think everyone runs these these tests in a containers anyway, and the TCs run with the mock decorator anyway, so I think it is still OK.
Contributor
Author
Thank you for letting me know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.