feat(agent): Add basic support for EKS Pods on Fargate #472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ferenc-
force-pushed
the
eks-support
branch
6 times, most recently
from
9b4869c to
241b42d
Compare
basti1302
reviewed
Nov 20, 2023
Ferenc-
force-pushed
the
eks-support
branch
2 times, most recently
from
bcb3ae2 to
597688d
Compare
Ferenc-
force-pushed
the
eks-support
branch
2 times, most recently
from
55745a8 to
6a334b2
Compare
Ferenc-
force-pushed
the
eks-support
branch
2 times, most recently
from
0bfa2d6 to
caceee6
Compare
pvital
approved these changes
Feb 12, 2024
Member
pvital
left a comment
pvital
left a comment
There was a problem hiding this comment.
It looks good to me.
My only suggestion is to change the c5666f3 commit message from test: Cover EKSFargateAgent to feat (test): Add EKSFargateAgent test cases since we are adding this whole set of test cases.
GSVarsha
reviewed
Feb 12, 2024
Member
Author
Done |
Signed-off-by: Ferenc Géczi <ferenc.geczi@ibm.com>
Signed-off-by: Ferenc Géczi <ferenc.geczi@ibm.com>
Signed-off-by: Ferenc Géczi <ferenc.geczi@ibm.com>
Signed-off-by: Ferenc Géczi <ferenc.geczi@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.