Fork missing spans fix #460
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ferenc-
requested changes
Oct 18, 2023
pvital
force-pushed
the
fork_missing_spans_fix
branch
from
ec04f7b to
c9267bf
Compare
pvital
force-pushed
the
fork_missing_spans_fix
branch
from
c9267bf to
2206e28
Compare
In multithreaded applications (services), only the first or master process is announced to the Agent when the service starts, but if a not announced forked process handles the (HTTP) ENTRY requests and it contains one or more EXIT spans created during the first request, those EXIT spans are missed and not reported. This fix returns True when agent.host.can_send() method is called and detects that the current process is a fork and has finished the announcement process to the Agent with a valid FSM state. Signed-off-by: Paulo Vital <paulo.vital@ibm.com>
Signed-off-by: Paulo Vital <paulo.vital@ibm.com>
pvital
force-pushed
the
fork_missing_spans_fix
branch
from
2206e28 to
3fa555c
Compare
Ferenc-
approved these changes
Nov 8, 2023
Member
Ferenc-
left a comment
Ferenc-
left a comment
There was a problem hiding this comment.
Approved for now. Let's wait with a new release until we have tracer test suite feedback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In multithreaded applications (services), only the first or master process is announced to the Agent when the service starts, but if a not announced forked process handles the (HTTP) ENTRY requests and it contains one or more EXIT spans created during the first request, those EXIT spans are missed and not reported.
This PR has a fix that returns
Truewhen theagent.host.can_send()method is called and detects the state machine is inwait4initorgood2gostates, which happens after the current process is announced to the Agent.