Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add custom legends to plots #43

Merged
merged 7 commits into from
Jan 30, 2024
Merged

Conversation

RuanJohn
Copy link
Collaborator

What?

Add support for passing in a custom legend mapping dictionary which maps algorithm names in the dataset to names to be displayed on plot legends.

Why?

It makes the plot legends look a lot nicer.

Extra

  • Added a small epsilon value to the normalisation in the data processing. This is to avoid accidentally dividing by 0.
  • Updated the tests to account for this.
  • Updated the example python file to use legend mapping and some of the plots in the quickstart notebook.

@RuanJohn RuanJohn added the enhancement New feature or request label Jan 17, 2024
@RuanJohn RuanJohn self-assigned this Jan 17, 2024
Copy link
Collaborator

@OmaymaMahjoub OmaymaMahjoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @RuanJohn for this PR just minor requests to edit the notebook and a sanity check assert line.

examples/quickstart.ipynb Show resolved Hide resolved
marl_eval/plotting_tools/plotting.py Show resolved Hide resolved
marl_eval/plotting_tools/plotting.py Show resolved Hide resolved
Copy link
Collaborator

@OmaymaMahjoub OmaymaMahjoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @RuanJohn

@RuanJohn RuanJohn merged commit a49c0cc into main Jan 30, 2024
3 checks passed
@RuanJohn RuanJohn deleted the feat/plot-time-and-custom-legends branch January 30, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants