-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding sokoban environment #185
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy with this, very minor comments! Thanks for all the work! 🔥
Co-authored-by: Clément Bonnet <56230714+clement-bonnet@users.noreply.github.com>
69738e3
Co-authored-by: Clément Bonnet <56230714+clement-bonnet@users.noreply.github.com>
Co-authored-by: Clément Bonnet <56230714+clement-bonnet@users.noreply.github.com>
Co-authored-by: Clément Bonnet <56230714+clement-bonnet@users.noreply.github.com>
Co-authored-by: Clément Bonnet <56230714+clement-bonnet@users.noreply.github.com>
Co-authored-by: Clément Bonnet <56230714+clement-bonnet@users.noreply.github.com>
Co-authored-by: Clément Bonnet <56230714+clement-bonnet@users.noreply.github.com>
Co-authored-by: Sasha <reallysasha@gmail.com>
Co-authored-by: Sasha <reallysasha@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the meantime we fix these write accesses, @djbyrne would you mind approving this one?
No description provided.