Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding sokoban environment #185

Merged
merged 95 commits into from
Feb 6, 2024
Merged

Conversation

mvmacfarlane
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Jul 17, 2023

CLA assistant check
All committers have signed the CLA.

@mvmacfarlane mvmacfarlane changed the title feat: adding boxoban environment feat: adding sokoban environment Jul 17, 2023
clement-bonnet
clement-bonnet previously approved these changes Jan 29, 2024
Copy link
Collaborator

@clement-bonnet clement-bonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!!

sash-a
sash-a previously approved these changes Jan 29, 2024
Copy link
Collaborator

@sash-a sash-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with this, very minor comments! Thanks for all the work! 🔥

Co-authored-by: Clément Bonnet <56230714+clement-bonnet@users.noreply.github.com>
@mvmacfarlane mvmacfarlane dismissed stale reviews from sash-a and clement-bonnet via 69738e3 February 3, 2024 13:23
mvmacfarlane and others added 14 commits February 3, 2024 13:23
Co-authored-by: Clément Bonnet <56230714+clement-bonnet@users.noreply.github.com>
Co-authored-by: Clément Bonnet <56230714+clement-bonnet@users.noreply.github.com>
Co-authored-by: Clément Bonnet <56230714+clement-bonnet@users.noreply.github.com>
Co-authored-by: Clément Bonnet <56230714+clement-bonnet@users.noreply.github.com>
Co-authored-by: Clément Bonnet <56230714+clement-bonnet@users.noreply.github.com>
Co-authored-by: Clément Bonnet <56230714+clement-bonnet@users.noreply.github.com>
Co-authored-by: Sasha <reallysasha@gmail.com>
Co-authored-by: Sasha <reallysasha@gmail.com>
clement-bonnet
clement-bonnet previously approved these changes Feb 5, 2024
Copy link
Collaborator

@clement-bonnet clement-bonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@clement-bonnet clement-bonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the meantime we fix these write accesses, @djbyrne would you mind approving this one?

@djbyrne djbyrne merged commit 632958f into instadeepai:main Feb 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants