Skip to content
This repository has been archived by the owner on Sep 20, 2021. It is now read-only.

BibFormat: add techreport as bibtex entry #266

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tsgit
Copy link
Contributor

@tsgit tsgit commented Jan 25, 2017

This recognizes 980__a:techreport and sets entry_type accordingly. Currently INSPIRE doesn't have any records marked as techreports, so this is just for code completeness.

Signed-off-by: Thorsten Schwander thorsten.schwander@gmail.com

@tsgit
Copy link
Contributor Author

tsgit commented Jan 25, 2017

@michamos as per standup discussion

@michamos
Copy link
Contributor

I am not sure that's the way to go, as in the schema possible document types have been standardized here and here.
I think we should rather decide whether 980__a:report == @techreport, and adapt the bibtex format accordingly. I don't have strong opinions on this, nor did anyone on standup apparently.

@tsgit
Copy link
Contributor Author

tsgit commented Jan 25, 2017

fine with me if it ever comes to that, by it didn't sound like "report" was considered equivalent to "techreport".
so this patch simply ensures that the code is clear about where in the code/when/how a techreport entry_type would be selected without actually changing anything for existing data.

as it is, nowhere in the code would entry_type techreport be assigned and so the conditional switches on techreport are somewhat misleading

@annetteholtkamp
Copy link

annetteholtkamp commented Jan 25, 2017 via email

    * 980__a:techreport recognized for entry_type

Signed-off-by: Thorsten Schwander <thorsten.schwander@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants