Helpdesk #137

inakidiazdecerio · 2018-05-17T06:51:23Z

Modifications in ATS for the following issues:

inspire-eu-validation/ets-repository#130
inspire-eu-validation/ets-repository#119
#130

Update branch "1.3" from changes to the master

Correct typo in schema-validation.md

@heidivanparys

Correct typo in Service keyword (Req 15) Thanks, @heidivanparys !

Correct formatting title Vocabulary Req. Thanks!

…PIRE themes, version 1.0" Date and title should be correct with respect to the given controlled vocabulary. For the "GEMET - INSPIRE themes, version 1.0" #132

…PIRE themes, version 1.0" Modifications in ATS - Date and date type should be checked if the thesaurus is "GEMET - INSPIRE themes, version 1.0" #132

…ribution The TG of the Download Services says that the ATOM feeds (the service one and the dataset ones) must be "application/atom+xml", so the metadata validator should accept ".atom" as a media type for distribution.

…md:DQ_DomainConsistency/gmd:result/gmd:DQ_ConformanceResult ETS checks if there is at least a gmd:report/gmd:DQ_DomainConsistency/gmd:result/gmd:DQ_ConformanceResult element. If there is none, a warning is thrown. If instead there is at least one, no error is reported. inspire-eu-validation/ets-repository#156

Since this is a requirement, we need to use "shall" (or must) rather than "should"

michellutz · 2018-07-01T17:18:35Z

iso-19115-19119/README.md

@@ -59,7 +59,7 @@ Based on requirement numbering in [TG MD](#ref_TG_MD).
 | 12     | Use language neutral name for serviceType | [Service type](http://inspire.ec.europa.eu/id/ats/metadata/1.3/iso-19115-19119/srv-type) |[IR MD](#ref_IR_MD) Part B 2.2 |
 | 13     | Provide at least one keyword         |[Keyword](http://inspire.ec.europa.eu/id/ats/metadata/1.3/iso-19115-19119/keyword) |[IR MD](#ref_IR_MD) Part B 3.1 |
 | 14     | Use theme for the only dataset keyword | [Dataset keyword](http://inspire.ec.europa.eu/id/ats/metadata/1.3/iso-19115-19119/ds-keyword) |[IR MD](#ref_IR_MD) Part B 3.1  |


As below: this should probably read: Provide at least one INSPIRE theme keyword

michellutz · 2018-07-01T17:18:51Z

iso-19115-19119/README.md

@@ -59,7 +59,7 @@ Based on requirement numbering in [TG MD](#ref_TG_MD).
 | 12     | Use language neutral name for serviceType | [Service type](http://inspire.ec.europa.eu/id/ats/metadata/1.3/iso-19115-19119/srv-type) |[IR MD](#ref_IR_MD) Part B 2.2 |
 | 13     | Provide at least one keyword         |[Keyword](http://inspire.ec.europa.eu/id/ats/metadata/1.3/iso-19115-19119/keyword) |[IR MD](#ref_IR_MD) Part B 3.1 |
 | 14     | Use theme for the only dataset keyword | [Dataset keyword](http://inspire.ec.europa.eu/id/ats/metadata/1.3/iso-19115-19119/ds-keyword) |[IR MD](#ref_IR_MD) Part B 3.1  |
-| 15     | Use category for the inly service keyword | [Service keyword](http://inspire.ec.europa.eu/id/ats/metadata/1.3/iso-19115-19119/srv-keyword) |[IR MD](#ref_IR_MD) Part B 1.5, Article 4, part D  |
+| 15     | Use category for the only service keyword | [Service keyword](http://inspire.ec.europa.eu/id/ats/metadata/1.3/iso-19115-19119/srv-keyword) |[IR MD](#ref_IR_MD) Part B 1.5, Article 4, part D  |


Strange English. I think it should be called: "Provide at least one service category keyword"

michellutz

There are still a number of things to be fixed. See detailed comments.

michellutz · 2018-07-02T07:38:00Z

iso-19115-19119/ds-specification.md

@@ -10,7 +10,7 @@ The test first checks if there is at least one [specification](#specification).
 It then performs the following checks
 *	The [specification](#specification) must contain an element of type gmd:CI_Citation/gmd:title which should not be an [empty characterstring](http://inspire.ec.europa.eu/id/ats/metadata/1.3/iso-19115-19119/README#emptychar)
 *	The [specification](#specification) must contain an element of type gmd:CI_Citation/gmd:date[./\*/gmd:dateType/\*/text()='{type}']/\*/gmd:date, where {type} is one of 'creation', 'revision' and 'publication'.
-*	The [specification](#specification) has gmd:DQ_DomainConsistency as a parent element.
+*	Metadata have at least one [DQ_ConformanceResult](#DQ_ConformanceResult) element.


I think this is wrong, and the original text is (kind of) correct. But the test (and the original requirement) are not formulated well. It should be similar to the test for req. 28 (which also needs to be revised - see below). Something like this:

This test case only applies to records with a hierarchyLevel value 'dataset' or 'series'.

For every gmd:report/gmd:DQ_DomainConsistency/gmd:result/gmd:DQ_ConformanceResult element, check if there is at least one specification. In case there is none, the test fails. If there is one, perform the following checks

The specification must contain an element of type gmd:CI_Citation/gmd:title which should not be an empty characterstring

The specification must contain an element of type gmd:CI_Citation/gmd:date[./*/gmd:dateType/*/text()='{type}']/*/gmd:date, where {type} is one of 'creation', 'revision' and 'publication'.

The gmd:DQ_ConformanceResult has an element gmd:pass that must contain a value of type gco:Boolean.

In addition, a fix should be implemented on ds-conformity.md, which should check if there is at least a gmd:report/gmd:DQ_DomainConsistency/gmd:result/gmd:DQ_ConformanceResult element citing to the INSPIRE implementing rules on interoperability of spatial data sets and services, according to the rules for specification and date elements specified in req. 29, i.e. with the same logic but concrete values for specification and date.

Thanks for the comments, the test have been modified according to you explanations.

We would like if you can help us with some doubs regarding the modifications under ds-conformity.md. You mention that we should implement the same logic the test before, but also checking concrete values for specification and date.After reviewing the TG, we did not found which concrete values are the requiered. Could you please detail us those concrete values?

This is the only pending modification for this Helpdesk pull request.

Please use the date, date type and title from this CI_Citation element (taken from v2.0 of the TG):

<gmd:CI_Citation> <gmd:title> <gmx:Anchor xlink:href="http://data.europa.eu/eli/reg/2010/1089">COMMISSION REGULATION (EU) No 1089/2010 of 23 November 2010 implementing Directive 2007/2/EC of the European Parliament and of the Council as regards interoperability of spatial data sets and services</gmx:Anchor> </gmd:title> <gmd:date> <gmd:CI_Date> <gmd:date> <gco:Date>2010-12-08</gco:Date> </gmd:date> <gmd:dateType> <gmd:CI_DateTypeCode codeList="http://standards.iso.org/iso/19139/resources/gmxCodelists.xml#gmxCodelists.xml#CI_DateTypeCode" codeListValue="publication">publication</gmd:CI_DateTypeCode> </gmd:dateType> </gmd:CI_Date> </gmd:date> </gmd:CI_Citation>

As discussed in the meeting on 9/8/18, the title text in the CI_Citation should be the title in the relevant MD language. The correct titles in the different languages are available in the language-specific files at http://inspire.ec.europa.eu/schemas/common/1.0/enums/

Dear @michellutz, could you please verify that the titles must be exactly the same that in the provided list. In some examples the words don't match because of uppercase and lowercase letters.

Thanks.

I would suggest that the strings should match, allowing for different capitalisation of words and also additional spaces, i.e. the following should all be a match for the normative text "COMMISSION REGULATION (EU) No 1089/2010 of 23 November 2010 implementing Directive 2007/2/EC of the European Parliament and of the Council as regards interoperability of spatial data sets and services":

Commission Regulation (EU) No 1089/2010 of 23 November 2010 implementing Directive 2007/2/EC of the European Parliament and of the Council as regards interoperability of spatial data sets and services

Commission regulation (EU) No 1089/2010 of 23 November 2010 implementing Directive 2007/2/EC of the European Parliament and of the Council as regards Interoperability of Spatial Data Sets and Services [note the additional spaces before and after "and"]

If this is difficult to implement, I would suggest simply checking two versions starting with "COMMISSION REGULATION ..." and "Commission Regulation ..."

michellutz · 2018-07-02T07:42:32Z

iso-19115-19119/srv-linkage.md

@@ -43,6 +43,8 @@ Since WCS and SOS are now also supported by technical guidance documents, the ET



Add a space after ## in the heading

michellutz · 2018-07-02T07:44:26Z

iso-19115-19119/srv-linkage.md

@@ -43,6 +43,8 @@ Since WCS and SOS are now also supported by technical guidance documents, the ET

 The namespace prefixes used as described in [README.md](http://inspire.ec.europa.eu/id/ats/metadata/1.3/iso-19115-19119/README#namespaces).

+The metadata validator should accept 'text/xml', 'application/xml', 'application/vnd.ogc.*' and 'application/atom' as a media type for distribution.


The media type check should be included in the test section, after "If one or more are provided: For each linkage the test checks, if the linkage element contains an element of type gmd:URL. Retrieve the resource at the URL using HTTP GET." At this point, a check for the media type should be added.

michellutz · 2018-07-02T07:53:24Z

iso-19115-19119/vocabulary.md

@@ -10,6 +10,7 @@ The test performs the following check for each [vocabulary](#thesaurus):
 * the node must contain a [title](#title) and should not be an [empty characterstring](http://inspire.ec.europa.eu/id/ats/metadata/1.3/iso-19115-19119/README#emptychar)
 * the node must contain a [date](#date)
 * the node must contain a [dateType](#dateType) which contains text that equals one of 'publication', 'revision' or 'creation'.
+* if the [title](#title) is 'GEMET - INSPIRE themes, version 1.0' the [date](#date) shall be '2008-06-01' and [dateType](#dateType) shall be 'publication'.


If think this check should not be included here, but in ds-keyword.md.

Slight rewording of the date and date time test.

Added more concrete details on the title, date and date type for [Regulation 1089/2010]

cportele and others added 15 commits February 22, 2017 17:28

Merge pull request #125 from inspire-eu-validation/master

53d5bae

Update branch "1.3" from changes to the master

Correct typo in schema-validation.md

5d7044c

Merge pull request #127 from heidivanparys/typo_schema_validation

5619ff8

Correct typo in schema-validation.md

Correct typo in Service keyword (Req 15)

d1633a3

Merge pull request #128 from heidivanparys/patch-1

3434adf

Correct typo in Service keyword (Req 15) Thanks, @heidivanparys !

Correct formatting title Vocabulary Req.

361fffc

Merge pull request #129 from heidivanparys/patch-2

20c971a

Correct formatting title Vocabulary Req. Thanks!

Add missing blank

7d0d5c3

Date and date type should be checked if the thesaurus is "GEMET - INS…

70b9ab3

…PIRE themes, version 1.0" Date and title should be correct with respect to the given controlled vocabulary. For the "GEMET - INSPIRE themes, version 1.0" #132

Update vocabulary.md

4ef9c13

Date and date type should be checked if the thesaurus is "GEMET - INS…

e28fe8c

…PIRE themes, version 1.0" Modifications in ATS - Date and date type should be checked if the thesaurus is "GEMET - INSPIRE themes, version 1.0" #132

Correction in ATS

1b39f4d

Update vocabulary.md

9b496bd

Since this is a requirement, we need to use "shall" (or must) rather than "should"

inakidiazdecerio assigned michellutz and AntoRot May 17, 2018

inakidiazdecerio requested review from michellutz and AntoRot June 22, 2018 12:13

michellutz reviewed Jul 1, 2018

View reviewed changes

michellutz requested changes Jul 2, 2018

View reviewed changes

inakidiazdecerio added 8 commits July 2, 2018 13:49

Update srv-linkage.md

2554b0f

Update README.md

bd37eff

Update README.md

36ed211

Update ds-specification.md

b76ef61

Update ds-specification.md

af29621

Update ds-keyword.md

35a0d10

Update vocabulary.md

6125959

Update ds-keyword.md

ba0b4df

inakidiazdecerio and others added 5 commits August 27, 2018 08:07

Update ds-specification.md

73ffa54

Update ds-conformity.md

581edb6

Update ds-conformity.md

b5799e7

Update ds-keyword.md

46ad001

Slight rewording of the date and date time test.

Update ds-conformity.md

9038955

Added more concrete details on the title, date and date type for [Regulation 1089/2010]

michellutz approved these changes Aug 28, 2018

View reviewed changes

michellutz merged commit e951de6 into master Aug 28, 2018

michellutz deleted the helpdesk branch August 28, 2018 14:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Helpdesk #137

Helpdesk #137

inakidiazdecerio commented May 17, 2018

michellutz Jul 1, 2018

michellutz Jul 1, 2018

michellutz left a comment

michellutz Jul 2, 2018

inakidiazdecerio Jul 20, 2018

michellutz Aug 2, 2018

michellutz Aug 10, 2018

inakidiazdecerio Aug 10, 2018

michellutz Aug 10, 2018 •

edited

Loading

michellutz Jul 2, 2018

michellutz Jul 2, 2018

michellutz Jul 2, 2018

		@@ -43,6 +43,8 @@ Since WCS and SOS are now also supported by technical guidance documents, the ET

		@@ -43,6 +43,8 @@ Since WCS and SOS are now also supported by technical guidance documents, the ET

		The namespace prefixes used as described in [README.md](http://inspire.ec.europa.eu/id/ats/metadata/1.3/iso-19115-19119/README#namespaces).

		The metadata validator should accept 'text/xml', 'application/xml', 'application/vnd.ogc.*' and 'application/atom' as a media type for distribution.

Helpdesk #137

Helpdesk #137

Conversation

inakidiazdecerio commented May 17, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

michellutz left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

michellutz Aug 10, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

michellutz Aug 10, 2018 •

edited

Loading