Skip to content

Make test for no proxy side-effects allow for no side-effects. #35

Closed
@jdalton

Description

Currently the tests for no proxy side-effects assume at least the ['getOwnPropertyDescriptor'] trap is triggered. When running say against require('node:util/types').isRegExp() it has for real real no side-effects and doesn't trigger ['getOwnPropertyDescriptor'], instead the result is []. The assumption could be tweaked to have ['getOwnPropertyDescriptor'] or less []. In my case I'm running against your unit tests so no pressure to change there. Just passing it along as a seen difference. If the tests are updated here I could pull them in directly.

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions