-
Notifications
You must be signed in to change notification settings - Fork 89
CHEF-19255 Fix pipe broken issue #818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sathish Babu <sbabu@progress.com>
Signed-off-by: Sathish Babu <sbabu@progress.com>
Signed-off-by: Sathish Babu <sbabu@progress.com>
…ions Signed-off-by: Sathish Babu <sbabu@progress.com>
Signed-off-by: Sathish Babu <sbabu@progress.com>
…d flushing Signed-off-by: Sathish Babu <sbabu@progress.com>
Signed-off-by: Sathish Babu <sbabu@progress.com>
Vasu1105
approved these changes
Jan 9, 2026
Contributor
Vasu1105
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but can we add test coverage?
…uisition Signed-off-by: Sathish Babu <sbabu@progress.com>
…Runner Signed-off-by: Sathish Babu <sbabu@progress.com>
…write and reader Signed-off-by: Sathish Babu <sbabu@progress.com>
Signed-off-by: Sathish Babu <sbabu@progress.com>
clintoncwolfe
approved these changes
Jan 12, 2026
Contributor
clintoncwolfe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closely read, looks good
ambar-kulkarni
approved these changes
Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves the security and reliability of named pipe communication in the
lib/train/transports/local.rbtransport by enforcing strict pipe ownership checks and handling pipe closure scenarios more gracefully. The main focus is on ensuring only the intended Windows user can access the named pipe and making the PowerShell server more robust.Description
Security and Access Control:
acquire_pipeto ensure that only the current Windows user can connect to the named pipe. If the pipe is owned by another user, an explicit error is raised to prevent unauthorized access.start_pipe_serverto explicitly set pipe security, granting full control only to the current user when creating the named pipe.current_windows_userandpipe_owned_by_current_user?to reliably determine the current user and verify pipe ownership before connecting.Reliability Improvements:
System.IO.IOException.Related Issue
Types of changes
Checklist: