Use only defined paths if specified (Fixes #216) #217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephen Hoekstra <shoekstra@schubergphilis.com>
|
This change looks beneficial but I'd wonder if any users are depending on the current odd behaviour, and would start to see their executed test suite be reduced after this merges. |
james-stocks
reviewed
May 6, 2020
| # get local tests and get run list of profiles | ||
| (local_suite_files + resolve_config_inspec_tests).compact.uniq | ||
| # get run list of profiles or fall back to local tests | ||
| return resolve_config_inspec_tests.uniq if resolve_config_inspec_tests |
There was a problem hiding this comment.
It looks like resolve_config_inspec_tests will always return an array and the if condition will always be true, making the next line unreachable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In reference to #216, this would be option 2 where default test directory is ignored if test paths are specified using
inspec_tests.