Add support for regional Google compute disk #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walterdolce
force-pushed
the
feature/add-support-for-regional-disks
branch
from
28f3216 to
21e2214
Compare
Signed-off-by: Walter Dolce <walterdolce@gmail.com>
slevenick
pushed a commit
to slevenick/inspec-gcp
that referenced
this pull request
Aug 22, 2019
Signed-off-by: Modular Magician <magic-modules@google.com>
|
Thanks for this @walterdolce ! To resolve the build failure, rebasing against master and making the following minor change should allow us to proceed e.g. Apologies for the pain editing the markdown table, I generate this automatically based on the files in the docs directory. Should probably commit that script somewhere and update the docs... |
A comment that causes a build to fail? 🤔 Is that expected? I'll do as instructed in the meantime.
That would be great 😄 |
Signed-off-by: Walter Dolce <walterdolce@gmail.com>
Signed-off-by: Walter Dolce <walterdolce@gmail.com>
|
@skpaterson all done! |
|
Awesome, thanks @walterdolce. |
skpaterson
pushed a commit
that referenced
this pull request
Aug 23, 2019
Signed-off-by: Modular Magician <magic-modules@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Walter Dolce walterdolce@gmail.com
Description
This PR adds support for verifying the state of regional disks.
Issues Resolved
#163
PS: changing the table in the README is a nightmare 😅