Skip to content

google_container_cluster method has_logging_enabled? reporting wrong #136

Closed
@janderton

Description

@janderton

The google_container_cluster method has_logging_enabled? reports false because its not matching "logging.googleapis.com" where the resource is sending "logging.googleapis.com/kubernetes" instead.

Here's the output of my testing:

     ✔  logging_service should not equal nil
     ×  logging_service should equal "logging.googleapis.com"

     expected #<String:83861140> => "logging.googleapis.com"
          got #<String:66556320> => "logging.googleapis.com/kubernetes"

     Compared using equal?, which compares object identity,
     but expected and actual are not the same object. Use
     `expect(actual).to eq(expected)` if you don't care about
     object identity in this example.


     ×  has_logging_enabled? should not equal false

     expected not #<FalseClass:0> => false
              got #<FalseClass:0> => false

     Compared using equal?, which compares object identity.

image

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions