Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chef 1095 Add the missing contents in the files of aws cloudtrail trail resource #969

Merged
merged 7 commits into from
Mar 30, 2023
Merged

Chef 1095 Add the missing contents in the files of aws cloudtrail trail resource #969

merged 7 commits into from
Mar 30, 2023

Conversation

soumyo13
Copy link
Contributor

@soumyo13 soumyo13 commented Feb 28, 2023 •
edited
Loading

Description

  1. Add the 2 attributes in the integration test of the singular resource.
  2. Add the 2 attributes in the docs of the singular resource.

Issues Resolved

NA

Check List

Please fill box or appropriate ([x]) or mark N/A.

@soumyo13
modifying the singular doc
a06fad2 
Signed-off-by: Soumyodeep Karmakar <soumyo.k13@gmail.com>
@soumyo13
adding the singular integration test
a18a689 
Signed-off-by: Soumyodeep Karmakar <soumyo.k13@gmail.com>
@soumyo13 soumyo13 requested a review from a team as a code owner February 28, 2023 14:39
@soumyo13 soumyo13 self-assigned this Feb 28, 2023
@netlify
Copy link

netlify bot commented Feb 28, 2023 •
edited
Loading

✅ Deploy Preview for inspec-aws ready!

Name Link
🔨 Latest commit 42f5657
🔍 Latest deploy log https://app.netlify.com/sites/inspec-aws/deploys/642200946c75440008176ce0
😎 Deploy Preview https://deploy-preview-969--inspec-aws.netlify.app/inspec/resources/aws_cloudtrail_trail
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@soumyo13
Copy link
Contributor Author

NOTE: Don't merge this PR until #967 is merged.

soumyo13 added 3 commits March 13, 2023 19:58
@soumyo13
adding the be_organization_trail
74ed19a 
Signed-off-by: Soumyodeep Karmakar <soumyo.k13@gmail.com>
@soumyo13
adding the be_organization_trail
9919313 
Signed-off-by: Soumyodeep Karmakar <soumyo.k13@gmail.com>
@soumyo13
resolved conflicts
9ec1863 
Signed-off-by: Soumyodeep Karmakar <soumyo.k13@gmail.com>
@soumyo13 soumyo13 requested a review from IanMadd March 24, 2023 11:15
IanMadd
IanMadd reviewed Mar 24, 2023
View reviewed changes
Copy link
Contributor

@IanMadd IanMadd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should all be trail not trial. Other than that, it looks good.

@soumyo13
minor doc fixes
3701e6e 
Signed-off-by: Soumyodeep Karmakar <soumyo.k13@gmail.com>
@soumyo13
Copy link
Contributor Author

These should all be trail not trial. Other than that, it looks good.

@IanMadd I have changed it. Please check.

@IanMadd
Docs edits
42f5657 
Signed-off-by: Ian Maddaus <ian.maddaus@progress.com>
@IanMadd IanMadd force-pushed the CHEF-1095-community-pr-add-attributes-s-3-key-prefix-organization-trail-in-the-integration-test-and-documentation-in-aws-cloudtrail-trail-resource branch from 6e52b15 to 42f5657 Compare March 27, 2023 20:46
@soumyo13 soumyo13 merged commit 195cf26 into main Mar 30, 2023
@soumyo13 soumyo13 deleted the CHEF-1095-community-pr-add-attributes-s-3-key-prefix-organization-trail-in-the-integration-test-and-documentation-in-aws-cloudtrail-trail-resource branch March 30, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IanMadd IanMadd IanMadd approved these changes

@sa-progress sa-progress sa-progress approved these changes

Assignees

@soumyo13 soumyo13

Labels
Do not merge Documentation ReadyForDocs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@soumyo13 @IanMadd @sa-progress