Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install missing dependencies (with --preact or --inferno flag) + Yarn support #214

Closed
wants to merge 13 commits into from
Closed

Install missing dependencies (with --preact or --inferno flag) + Yarn support #214

wants to merge 13 commits into from

Conversation

ntwcklng
Copy link
Contributor

Related: #201

@ntwcklng
Copy link
Contributor Author

Maybe this PR is also a good place for #204?

@insin
Copy link
Owner

insin commented Dec 21, 2016

This probably is a good place to do that, then we can have a separate install function which handles choosing between nwb and yarn, and manages the spinner stuff etc, so the caller just has to provide a list of modules to be installed.

@ntwcklng
Copy link
Contributor Author

Okay.
I noticed that src/commands/build-react.js isn't used anywhere. Should we ditch it or make it an alias for build-react-app?

@ntwcklng ntwcklng changed the title Install missing dependencies (with --preact or --inferno flag) Install missing dependencies (with --preact or --inferno flag) + Yarn support Dec 21, 2016
@insin
Copy link
Owner

insin commented Dec 21, 2016

build-react and serve-react are used by src/bin/react.js - they're named that way because you don't need to set up a react app to use them, just point at an entry module.

@insin insin force-pushed the next branch 2 times, most recently from fbed432 to e46d1ba Compare December 31, 2016 07:31
@ntwcklng
Copy link
Contributor Author

@insin i see you already created a new install function, so this PR is needless. Is there anything else i can help you with?

@insin
Copy link
Owner

insin commented Jan 10, 2017

@ntwcklng apologies for digging a big hole under the work you did on this - I needed an install function which could check for resolvable dependencies while implementing inferno build, as this was a blocker for being able to bundle a module which exports a component, but it turned out generic enough to use everywhere else.

I'm also almost done rewriting most of createProject.js to remove synchronous bits and reduce duplication, as it became a copy and paste mess as I added more project types.

In places you find synchronous stuff or lots of copy and paste in nwb it's usually just me being lazy because I needed it to work now rather than having to deal with figuring things out properly, but I've finally been in the mood to fix things recently due to diving into Preact and Inferno.

Let's see where the dust settles after v0.14.

@ntwcklng
Copy link
Contributor Author

Okay, i will close this PR for now 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants