Skip to content

Conversation

@m7pr
Copy link
Contributor

@m7pr m7pr commented Nov 6, 2025

Part of #1600

module_snapshot_manager + friends

@m7pr m7pr added the core label Nov 6, 2025
@m7pr
Copy link
Contributor Author

m7pr commented Nov 6, 2025

Hey, changing to regular PR to start tests, because they dont work for me locally

@m7pr m7pr marked this pull request as ready for review November 6, 2025 12:47
@m7pr m7pr changed the title module_bookmark_manager tests [WIP] module_bookmark_manager and module_snapshot_manager tests [WIP] Nov 6, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2025

Unit Tests Summary

  1 files   33 suites   2m 32s ⏱️
384 tests 318 ✅ 66 💤 0 ❌
614 runs  548 ✅ 66 💤 0 ❌

Results for commit 6031170.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2025

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
module_teal 💚 $124.23$ $-4.59$ $+14$ $0$ $0$ $0$
module_teal_data 👶 $+0.71$ $+6$ $0$ $0$ $0$
reporter_previewer_module 👶 $+0.08$ $+15$ $0$ $0$ $0$
validations 👶 $+0.94$ $+28$ $0$ $0$ $0$
zzz 👶 $+0.05$ $+18$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
module_teal 👶 $+0.38$ adds_snapshot_to_history_when_name_is_provided
module_teal 👶 $+0.27$ extends_snapshot_list_content_when_snapshots_exist
module_teal 👶 $+0.39$ handles_multiple_snapshots_correctly
module_teal 👶 $+0.21$ opens_snapshot_manager_modal_when_show_button_is_clicked
module_teal 👶 $+0.29$ rejects_duplicate_snapshot_name
module_teal 👶 $+0.25$ rejects_empty_snapshot_name
module_teal 👶 $+0.50$ restores_specific_snapshot_when_select_button_is_clicked
module_teal 👶 $+0.19$ sets_empty_snapshot_list_message_when_no_snapshots_exist
module_teal 👶 $+0.22$ shows_upload_modal_when_upload_button_is_clicked
module_teal 👶 $+0.05$ snapshot_history_contains_initial_snapshot_on_init
module_teal 👶 $+0.31$ trims_whitespace_from_snapshot_name
module_teal_data 👶 $+0.13$ srv_teal_data_module_handles_error_in_data_module_via_srv_teal
module_teal_data 👶 $+0.19$ srv_teal_data_module_handles_valid_teal_data_via_srv_teal
module_teal_data 👶 $+0.17$ srv_validate_reactive_teal_data_handles_qenv.error_via_srv_teal
module_teal_data 👶 $+0.14$ srv_validate_reactive_teal_data_handles_shiny.error_via_srv_teal
module_teal_data 👶 $+0.08$ ui_teal_data_module_returns_tagList_with_wrapper_and_validation_UI_via_init
reporter_previewer_module 👶 $+0.01$ accepts_valid_server_args
reporter_previewer_module 👶 $+0.01$ creates_module_with_server_and_ui_functions
reporter_previewer_module 👶 $+0.00$ processes_multiple_server_args
reporter_previewer_module 👶 $+0.02$ returns_teal_module_with_previewer_class
reporter_previewer_module 👶 $+0.00$ stores_server_args
reporter_previewer_module 👶 $+0.01$ throws_error_when_label_is_not_a_string
reporter_previewer_module 👶 $+0.01$ throws_error_when_server_args_has_invalid_names
reporter_previewer_module 👶 $+0.01$ throws_error_when_server_args_is_not_a_named_list
reporter_previewer_module 👶 $+0.01$ uses_default_label
validations 👶 $+0.00$ validate_has_elements_passes_when_x_has_elements
validations 👶 $+0.01$ validate_has_elements_throws_error_when_x_is_empty
validations 👶 $+0.00$ validate_has_variable_passes_when_variable_exists
validations 👶 $+0.00$ validate_has_variable_passes_when_varname_is_empty
validations 👶 $+0.01$ validate_has_variable_throws_error_when_variable_is_missing
validations 👶 $+0.01$ validate_has_variable_uses_custom_message_when_provided
validations 👶 $+0.79$ validate_has_variable_works_with_multiple_variables
validations 👶 $+0.00$ validate_in_passes_when_x_is_in_choices
validations 👶 $+0.01$ validate_in_throws_error_when_choices_is_empty
validations 👶 $+0.01$ validate_in_throws_error_when_x_is_empty
validations 👶 $+0.01$ validate_in_throws_error_when_x_is_not_in_choices
validations 👶 $+0.01$ validate_in_works_with_multiple_values
validations 👶 $+0.00$ validate_n_levels_passes_when_levels_are_within_range
validations 👶 $+0.01$ validate_n_levels_throws_error_when_levels_greater_than_max_levels
validations 👶 $+0.01$ validate_n_levels_throws_error_when_levels_less_than_min_levels
validations 👶 $+0.00$ validate_n_levels_works_when_both_min_and_max_are_NULL
validations 👶 $+0.00$ validate_n_levels_works_with_non_factor_vectors
validations 👶 $+0.01$ validate_n_levels_works_with_only_max_levels
validations 👶 $+0.01$ validate_n_levels_works_with_only_min_levels
validations 👶 $+0.00$ validate_no_intersection_passes_when_x_and_y_do_not_intersect
validations 👶 $+0.01$ validate_no_intersection_throws_error_when_x_and_y_intersect
validations 👶 $+0.00$ validate_one_row_per_id_passes_when_no_duplicates_exist
validations 👶 $+0.01$ validate_one_row_per_id_throws_error_when_duplicates_exist
validations 👶 $+0.00$ validate_one_row_per_id_uses_default_key
zzz 👶 $+0.01$ .onAttach_packageStartupMessage_includes_version_number_in_message
zzz 👶 $+0.01$ .onAttach_packageStartupMessage_shows_version_message
zzz 👶 $+0.02$ .onLoad_Initialised_options_on_package_load_are_retained_and_not_overwritten
zzz 👶 $+0.02$ .onLoad_Initialised_options_on_package_load_that_are_unset_are_loaded_with_defaults

Results for commit 6096a20

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2025

badge

Code Coverage Summary

Filename                          Stmts    Miss  Cover    Missing
------------------------------  -------  ------  -------  ---------------------------------------------------------------------------------------
R/after.R                            59      21  64.41%   42-52, 64, 69, 77-79, 81-89, 100, 104-105
R/checkmate.R                        24       0  100.00%
R/dummy_functions.R                  61       2  96.72%   44, 46
R/include_css_js.R                   11       0  100.00%
R/init.R                            152       1  99.34%   299
R/module_bookmark_manager.R         153     117  23.53%   54-58, 78-133, 138-139, 151, 198, 233-310
R/module_data_summary.R             177       8  95.48%   40, 50, 205, 236-240
R/module_filter_data.R               64       0  100.00%
R/module_filter_manager.R           229      50  78.17%   72-81, 89-94, 107-111, 116-117, 290-313, 339, 366, 378, 385-386
R/module_init_data.R                 84       6  92.86%   38-43
R/module_nested_tabs.R              371      37  90.03%   163, 267-282, 302-306, 324, 361, 479-482, 486-489, 493-496, 541
R/module_session_info.R              18       0  100.00%
R/module_snapshot_manager.R         272      41  84.93%   164-165, 280, 284-288, 290-296, 299-312, 315-323, 373, 376-378
R/module_source_code.R               69       0  100.00%
R/module_teal_data.R                149      76  48.99%   43-149
R/module_teal_lockfile.R            131      53  59.54%   45-57, 60-62, 76, 86-88, 100-102, 110-119, 122, 124, 126-127, 142-146, 161-162, 177-186
R/module_teal_reporter.R            122       9  92.62%   60, 77-78, 81, 98, 128, 142, 144, 158
R/module_teal.R                     213      28  86.85%   130, 134-135, 145-146, 186, 204-220, 222, 255-256, 263-264
R/module_transform_data.R           116       6  94.83%   46, 130-134
R/modules.R                         291      51  82.47%   170-174, 229-232, 356-376, 384, 390, 567-573, 586-594, 609-624
R/reporter_previewer_module.R        41      12  70.73%   41, 45, 68-85
R/teal_data_module-eval_code.R       23       0  100.00%
R/teal_data_module-within.R           7       0  100.00%
R/teal_data_module.R                 20       0  100.00%
R/teal_data_utils.R                  49       0  100.00%
R/teal_modifiers.R                   57       0  100.00%
R/teal_slices-store.R                29       0  100.00%
R/teal_slices.R                      63       0  100.00%
R/teal_transform_module.R            45       0  100.00%
R/TealAppDriver.R                   298     298  0.00%    50-621
R/utils.R                           291      48  83.51%   402-451, 539-548
R/validate_inputs.R                  32       0  100.00%
R/validations.R                      58       0  100.00%
R/zzz.R                              19       0  100.00%
TOTAL                              3798     864  77.25%

Diff against main

Filename                         Stmts    Miss  Cover
-----------------------------  -------  ------  -------
R/module_snapshot_manager.R         +1    -153  +56.51%
R/reporter_previewer_module.R        0     -29  +70.73%
R/validations.R                      0     -37  +63.79%
R/zzz.R                              0     -15  +78.95%
TOTAL                               +1    -234  +7.59%

Results for commit: 6031170

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@m7pr
Copy link
Contributor Author

m7pr commented Nov 6, 2025

For now, covr stats, will try to improve

R/module_bookmark_manager.R: 28.76%
R/module_teal_data.R: 48.99%
R/module_snapshot_manager.R: 59.19%

@m7pr
Copy link
Contributor Author

m7pr commented Nov 6, 2025

Current:

teal Coverage: 72.94%

R/module_bookmark_manager.R: 25.49%
R/module_snapshot_manager.R: 83.82%
R/zzz.R: 100.00%

@gogonzo gogonzo self-assigned this Nov 7, 2025
@m7pr m7pr changed the title module_bookmark_manager and module_snapshot_manager tests [WIP] zzz.R, module_bookmark_manager.R and module_snapshot_manager.R tests [WIP] Nov 7, 2025
@m7pr m7pr changed the title zzz.R, module_bookmark_manager.R and module_snapshot_manager.R tests [WIP] [WIP] improve covr tests [WIP] Nov 7, 2025
@m7pr
Copy link
Contributor Author

m7pr commented Nov 7, 2025

Current

teal Coverage: 76.49%
R/reporter_previewer_module.R: 0.00%
R/TealAppDriver.R: 0.00%
R/module_bookmark_manager.R: 25.49%
R/module_teal_data.R: 48.99%
R/module_teal_lockfile.R: 59.54%
R/after.R: 64.41%
R/module_filter_manager.R: 78.17%
R/modules.R: 82.47%
R/utils.R: 83.51%
R/module_snapshot_manager.R: 83.82%
R/module_teal.R: 86.85%
R/module_nested_tabs.R: 90.03%
R/module_teal_reporter.R: 92.62%
R/module_init_data.R: 92.86%
R/module_transform_data.R: 94.83%
R/module_data_summary.R: 95.48%
R/dummy_functions.R: 96.72%
R/init.R: 99.34%
R/checkmate.R: 100.00%
R/include_css_js.R: 100.00%
R/module_filter_data.R: 100.00%
R/module_session_info.R: 100.00%
R/module_source_code.R: 100.00%
R/teal_data_module-eval_code.R: 100.00%
R/teal_data_module-within.R: 100.00%
R/teal_data_module.R: 100.00%
R/teal_data_utils.R: 100.00%
R/teal_modifiers.R: 100.00%
R/teal_slices-store.R: 100.00%
R/teal_slices.R: 100.00%
R/teal_transform_module.R: 100.00%
R/validate_inputs.R: 100.00%
R/validations.R: 100.00%
R/zzz.R: 100.00%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants