1076 reorder formals #1080
Merged
1076 reorder formals #1080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chlebowa
changed the title
averissimo
approved these changes
Feb 1, 2024
Contributor
averissimo
left a comment
averissimo
left a comment
There was a problem hiding this comment.
Looks good. Funny how we were already using this order in the getting-started-with-team.Rmd
There's another checkmate::check_*" on srv_teal_with_splash()`, include it here or let's just push it to the pre-release branch
srv_teal_with_splash <- function(id, data, modules, filter = teal_slices()) {
checkmate::assert_character(id, max.len = 1, any.missing = FALSE)
checkmate::check_multi_class(data, c("teal_data", "teal_data_module")) # <-
# ...
Contributor
Author
The Natural Order of Things 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1076