1009 fix skipped tests #1038
Merged
1009 fix skipped tests #1038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
averissimo
reviewed
Jan 10, 2024
Co-authored-by: André Veríssimo <211358+averissimo@users.noreply.github.com> Signed-off-by: Aleksander Chlebowski <114988527+chlebowa@users.noreply.github.com>
…re-release-cleanup@main
…re-release-cleanup@main
Contributor
Author
|
No more skipped tests. |
averissimo
approved these changes
Jan 18, 2024
Contributor
averissimo
left a comment
averissimo
left a comment
There was a problem hiding this comment.
Looks good! I think it can be merged as is.
Feel free to accept or discard my only comment as you see best.
I did found an issue when inspecting the teal.data contents, as the hash of data[["d2"]] does not match the initial hash.
Issue created on {teal.slice} insightsengineering/teal.slice#527
rlang::hash(data[["d2"]])
#> [1] "fed25eb8e9c06544ff433b8cbb15379f"
Comment on lines
+409
to
+410
| "stopifnot(rlang::hash(d1) == \"f6f90d2c133ca4abdeb2f7a7d85b731e\")", | ||
| "stopifnot(rlang::hash(d2) == \"6e30be195b7d914a1311672c3ebf4e4f\")", |
Contributor
There was a problem hiding this comment.
I don't feel strongly about this, but consider generating the hash live
Suggested change
| "stopifnot(rlang::hash(d1) == \"f6f90d2c133ca4abdeb2f7a7d85b731e\")", | |
| "stopifnot(rlang::hash(d2) == \"6e30be195b7d914a1311672c3ebf4e4f\")", | |
| paste0( | |
| "stopifnot(rlang::hash(d1) == \"", | |
| rlang::hash(data.frame(id = 1:5, pk = c(2, 3, 2, 1, 4), val = 1:5)), | |
| "\")" | |
| ), | |
| paste0( | |
| "stopifnot(rlang::hash(d2) == \"", | |
| rlang::hash(data.frame(id = 1:5, value = 1:5)), | |
| "\")" | |
| ), |
3 tasks
Contributor
Author
I don't quite understand. This is not connected to this issue, is it? |
Contributor
|
@chlebowa I was mentioning the suggestion that calculates the hash instead of using a manual string. Doesn't matter now :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1009