Skip to content

Conversation

@m7pr
Copy link
Contributor

@m7pr m7pr commented Aug 11, 2025

Part of https://github.com/insightsengineering/coredev-tasks/issues/649

Removed stable badges.
Removed experimental badges that were edited at 0.4.1 (so probably introduced earlier) during #176, but now we have 0.6.0 on CRAN.

@m7pr m7pr requested a review from gogonzo August 11, 2025 10:24
@m7pr m7pr added the core label Aug 11, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 11, 2025

badge

Code Coverage Summary

Filename                          Stmts    Miss  Cover    Missing
------------------------------  -------  ------  -------  ------------------------------------------------------------------------------
R/call_utils.R                      156     124  20.51%   19-28, 65, 67, 69, 102-345
R/check_selector.R                   33       0  100.00%
R/choices_labeled.R                 157      27  82.80%   67, 73, 78, 85, 101, 218-222, 226-231, 354-355, 357, 363, 390-397
R/choices_selected.R                 81      11  86.42%   211-237, 274
R/column_functions.R                  3       3  0.00%    15-18
R/data_extract_datanames.R           30       8  73.33%   15-19, 80-82
R/data_extract_filter_module.R      105      47  55.24%   95-108, 111-112, 114-131, 147-166
R/data_extract_module.R             305      67  78.03%   139, 144, 161, 164-169, 171, 190-193, 223-269, 507, 512, 688, 699-700, 778-783
R/data_extract_read_module.R        137       7  94.89%   34, 39-41, 43, 138, 155
R/data_extract_select_module.R       32      18  43.75%   29-46
R/data_extract_single_module.R       60       2  96.67%   30, 43
R/data_extract_spec.R                32       0  100.00%
R/delayed_choices.R                  34       6  82.35%   86, 95-99
R/filter_spec.R                     186       1  99.46%   279
R/format_data_extract.R              16       1  93.75%   48
R/get_dplyr_call.R                  297       0  100.00%
R/get_merge_call.R                  278      29  89.57%   31-37, 48, 214-223, 388, 404-416
R/input_checks.R                     11       2  81.82%   15-16
R/merge_data_utils.R                  2       0  100.00%
R/merge_datasets.R                  134       6  95.52%   122, 248-252
R/merge_expression_module.R          60      11  81.67%   160-165, 183, 359-364
R/Queue.R                            23       0  100.00%
R/resolve_delayed.R                  16       4  75.00%   76-79
R/resolve.R                         115      45  60.87%   46, 180-286
R/select_spec.R                      64       8  87.50%   98, 178-185
R/utils.R                            37      24  35.14%   31-44, 172-185
R/zzz.R                               3       3  0.00%    2-4
TOTAL                              2407     454  81.14%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: df4b1cc

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

github-actions bot commented Aug 11, 2025

Unit Tests Summary

  1 files   24 suites   6s ⏱️
194 tests 194 ✅ 0 💤 0 ❌
698 runs  698 ✅ 0 💤 0 ❌

Results for commit df4b1cc.

♻️ This comment has been updated with latest results.

@gogonzo gogonzo self-assigned this Aug 11, 2025
Copy link
Contributor

@gogonzo gogonzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lifecycle is no longer needed in a package. Please remove all occurrences (@import tags and description/suggests)

@m7pr m7pr requested a review from gogonzo August 11, 2025 14:26
@m7pr
Copy link
Contributor Author

m7pr commented Aug 11, 2025

Good catch! Removed in df4b1cc

Copy link
Contributor

@gogonzo gogonzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@m7pr m7pr merged commit 9c6186c into main Aug 12, 2025
29 of 30 checks passed
@m7pr m7pr deleted the lifecycle@main branch August 12, 2025 06:54
@github-actions github-actions bot locked and limited conversation to collaborators Aug 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants