Skip to content

Conversation

@donyunardi
Copy link
Contributor

Fixes https://github.com/insightsengineering/coredev-tasks/issues/627

Since the UI changes, data_extract_single_ui returns different length elements.

@donyunardi donyunardi requested a review from a team March 15, 2025 03:06
@github-actions
Copy link
Contributor

github-actions bot commented Mar 15, 2025

Unit Tests Summary

  1 files   24 suites   7s ⏱️
194 tests 194 ✅ 0 💤 0 ❌
697 runs  697 ✅ 0 💤 0 ❌

Results for commit 2ba6bfc.

♻️ This comment has been updated with latest results.

@donyunardi
Copy link
Contributor Author

The R CMD Check is failing because the test ran against the 0.16.0 release with the old UI.
This PR will fix the integration test, but R CMD Check will still fail, which might reflect poorly in the package info.

@m7pr is this the case where we should add the affected packages to Remotes field so that it will pull the latest UI design?

@donyunardi
Copy link
Contributor Author

CICD failed because tj-actions is not available. Will try again later.
image

@github-actions
Copy link
Contributor

badge

Code Coverage Summary

Filename                          Stmts    Miss  Cover    Missing
------------------------------  -------  ------  -------  ------------------------------------------------------------------------------
R/call_utils.R                      156     124  20.51%   19-28, 65, 67, 69, 102-345
R/check_selector.R                   33       0  100.00%
R/choices_labeled.R                 157      27  82.80%   68, 74, 79, 86, 102, 220-224, 228-233, 357-358, 360, 366, 393-400
R/choices_selected.R                 81      11  86.42%   214-242, 279
R/column_functions.R                  3       3  0.00%    15-18
R/data_extract_datanames.R           30       8  73.33%   16-20, 83-85
R/data_extract_filter_module.R      105      47  55.24%   95-108, 111-112, 114-131, 147-166
R/data_extract_module.R             298      67  77.52%   128, 133, 150, 153-158, 160, 179-182, 212-258, 497, 502, 679, 690-691, 769-774
R/data_extract_read_module.R        137       7  94.89%   34, 39-41, 43, 138, 155
R/data_extract_select_module.R       32      18  43.75%   29-46
R/data_extract_single_module.R       60       2  96.67%   30, 43
R/data_extract_spec.R                32       0  100.00%
R/delayed_choices.R                  34       6  82.35%   87, 96-100
R/filter_spec.R                     186       1  99.46%   280
R/format_data_extract.R              16       1  93.75%   48
R/get_dplyr_call.R                  297       0  100.00%
R/get_merge_call.R                  278      29  89.57%   32-38, 49, 215-224, 391, 407-419
R/include_css_js.R                    5       0  100.00%
R/input_checks.R                     11       2  81.82%   17-18
R/merge_data_utils.R                  2       0  100.00%
R/merge_datasets.R                  134       6  95.52%   123, 249-253
R/merge_expression_module.R          60      11  81.67%   161-166, 184, 362-367
R/Queue.R                            23       0  100.00%
R/resolve_delayed.R                  16       4  75.00%   78-81
R/resolve.R                         115      45  60.87%   48, 182-288
R/select_spec.R                      64       8  87.50%   99, 179-186
R/utils.R                            37      24  35.14%   33-46, 174-187
R/zzz.R                               3       3  0.00%    2-4
TOTAL                              2405     454  81.12%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 2ba6bfc

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@donyunardi donyunardi merged commit c8d8a22 into main Mar 17, 2025
61 of 77 checks passed
@donyunardi donyunardi deleted the 627_fix_unit_test@main branch March 17, 2025 13:07
@github-actions github-actions bot locked and limited conversation to collaborators Mar 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants