Skip to content

Conversation

@kartikeyakirar
Copy link
Contributor

part of #176

I have made minor updates as part of review process

  • updated document
  • changed tags
  • added some punctuations
  • removed unused variable.

@averissimo averissimo self-assigned this Feb 14, 2024
Merge branch '178_pre-release-cleanup@main' into minor_update@178_pe-release-cleanup@main

# Conflicts:
#	R/choices_selected.R
#	man/choices_selected.Rd
Copy link
Contributor

@averissimo averissimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, left some comments that may require a bit of discussion.

Do you want to huddle for a fast resolution?

kartikeyakirar and others added 5 commits February 14, 2024 19:18
Co-authored-by: André Veríssimo <211358+averissimo@users.noreply.github.com>
Signed-off-by: kartikeya kirar <kirar.kartikeya1@gmail.com>
Co-authored-by: André Veríssimo <211358+averissimo@users.noreply.github.com>
Signed-off-by: kartikeya kirar <kirar.kartikeya1@gmail.com>
Co-authored-by: André Veríssimo <211358+averissimo@users.noreply.github.com>
Signed-off-by: kartikeya kirar <kirar.kartikeya1@gmail.com>
Copy link
Contributor

@averissimo averissimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kartikeyakirar kartikeyakirar merged commit 8296b88 into 178_pre-release-cleanup@main Feb 14, 2024
@kartikeyakirar kartikeyakirar deleted the minor_update@178_pe-release-cleanup@main branch February 14, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants