Skip to content

start and end date validation in filter #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Feb 21, 2023
Merged

start and end date validation in filter #202

merged 9 commits into from
Feb 21, 2023

Conversation

@BLAZEWIM
Copy link
Contributor

@BLAZEWIM BLAZEWIM commented Feb 17, 2023 •
edited
Loading

Pull Request

Fixes #158

  1. At initialization, when values are not valid, corrections will be performed with warnings.
  2. Later, when changed by the user, shinyvalidate is used.

Example to test:

adsl <- synthetic_cdisc_dataset("latest", "adsl")

app <- init(
  data = teal_data(dataset("ADSL", adsl)),
  modules = example_module(),
  filter = list(
    "ADSL" = list(
      RANDDT = list(selected = c("2021-02-16", "2021-02-17")),
      TRT01SDTM = list(selected = c("2021-02-11 17:09:18", "2021-02-10 20:42:27"))
    )
  )
)
runApp(app)

@BLAZEWIM BLAZEWIM marked this pull request as ready for review February 20, 2023 15:56
@BLAZEWIM BLAZEWIM added the bug Something isn't working label Feb 20, 2023
@BLAZEWIM BLAZEWIM changed the title simple solution start and end date validation in filter Feb 20, 2023
@BLAZEWIM BLAZEWIM added the core label Feb 20, 2023
gogonzo
gogonzo reviewed Feb 21, 2023
View reviewed changes
Copy link
Contributor

@gogonzo gogonzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 please add a NEWS entry for this

@gogonzo gogonzo self-assigned this Feb 21, 2023
BLAZEWIM and others added 4 commits February 21, 2023 09:17
@BLAZEWIM @gogonzo
Update R/FilterStateDate.R
8add176 
Co-authored-by: Dawid Kałędkowski <6959016+gogonzo@users.noreply.github.com>
Signed-off-by: Marek Blazewicz <110387997+BLAZEWIM@users.noreply.github.com>
@BLAZEWIM @gogonzo
Update R/FilterStateDatettime.R
d3834e3 
Co-authored-by: Dawid Kałędkowski <6959016+gogonzo@users.noreply.github.com>
Signed-off-by: Marek Blazewicz <110387997+BLAZEWIM@users.noreply.github.com>
@BLAZEWIM
changed replacing by setting default range
2c60453
@BLAZEWIM
news updated
7d8c6a1
@gogonzo
Copy link
Contributor

gogonzo commented Feb 21, 2023

👍 cleared to go

@BLAZEWIM BLAZEWIM merged commit ac6ca0b into filter_panel_refactor@main Feb 21, 2023
@BLAZEWIM BLAZEWIM deleted the 158_date_validation@filter_panel_refactor@main branch February 21, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gogonzo gogonzo gogonzo left review comments

Assignees

@gogonzo gogonzo

Labels

bug Something isn't working core

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BLAZEWIM @gogonzo