183 choicefs improve init #194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marek Blazewicz <110387997+BLAZEWIM@users.noreply.github.com>
mhallal1
reviewed
Feb 14, 2023
gogonzo
reviewed
Feb 14, 2023
mhallal1
reviewed
Feb 14, 2023
gogonzo
reviewed
Feb 14, 2023
Contributor
gogonzo
left a comment
gogonzo
left a comment
There was a problem hiding this comment.
Please change x_reactive to have no defaults in init. Please fix the assert to not let x_reactive to be NULL, it has to be a reactive.
Please fix the get_filtered_counts() call mentioned below.
Besides, it's looking good
Co-authored-by: Mahmoud Hallal <86970066+mhallal1@users.noreply.github.com> Signed-off-by: Marek Blazewicz <110387997+BLAZEWIM@users.noreply.github.com>
Co-authored-by: Dawid Kałędkowski <6959016+gogonzo@users.noreply.github.com> Signed-off-by: Marek Blazewicz <110387997+BLAZEWIM@users.noreply.github.com>
mhallal1
reviewed
Feb 15, 2023
| testthat::expect_no_error(ChoicesFilterState$new(as.factor("test"), reactive(NULL), varname = "test")) | ||
| }) | ||
|
|
||
| testthat::test_that("The constructor reactive as x_reactive", { |
Contributor
There was a problem hiding this comment.
testthat::test_that("The constructor accepts only reactive input for x_reactive", {
mhallal1
approved these changes
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Fixes #183