{teal} module returns a teal_report object that extends from teal_data
#884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 3, 2025
{teal} module returns a teal_report object that extends from teal_data
insightsengineering/teal#1541
Open
|
Code Coverage SummaryDiff against mainResults for commit: f0600dc Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Unit Tests Summary 1 files 22 suites 2s ⏱️ Results for commit f0600dc. ♻️ This comment has been updated with latest results. |
Companion to insightsengineering/teal.reporter#334 Consequence of changing naming convention for `teal_report` object. --------- Co-authored-by: André Veríssimo <211358+averissimo@users.noreply.github.com>
averissimo
added a commit
to insightsengineering/teal.code
that referenced
this pull request
Jun 12, 2025
…l_data` (#255) # Pull Request Fixes: - insightsengineering/teal#1526 Built on top of: - insightsengineering/teal.reporter#307 - _(#307 will be closed once this PR is stable)_ ### Companion PRs: - insightsengineering/teal#1541 - #255 - insightsengineering/teal.data#370 - insightsengineering/teal.reporter#331 - insightsengineering/teal.modules.general#884 ### Changes description - [x] Add new parameter `cache` - Caches the result of the last evaluation in the respective `@code` slot - [ ] Decide on name - [x] Remove signature with multiple arguments to allow overriding `eval_code` in other packages without showing a note ``` r pkgload::load_all("teal.code") #> ℹ Loading teal.code q <- qenv() |> eval_code(1 + 1, cache = TRUE) |> eval_code(mtcars <- head(mtcars)) attr(q@code[[1]], "cache") #> [1] 2 ``` <sup>Created on 2025-06-03 with [reprex v2.1.1](https://reprex.tidyverse.org)</sup> --------- Co-authored-by: Dawid Kaledkowski <dawid.kaledkowski@gmail.com> Co-authored-by: Marcin <133694481+m7pr@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
averissimo
added a commit
to insightsengineering/teal.data
that referenced
this pull request
Jun 12, 2025
…l_data` (#370) # Pull Request Fixes: - insightsengineering/teal#1526 Built on top of: - insightsengineering/teal.reporter#307 - _(#307 will be closed once this PR is stable)_ ### Companion PRs: - insightsengineering/teal#1541 - insightsengineering/teal.code#255 - #370 - insightsengineering/teal.reporter#331 - insightsengineering/teal.modules.general#884 ### Changes description - [x] Cleanup of `teal_data` class to allow for `teal_report` extension - [x] Change the `show()` method to remove reference to `teal_data` specifically --------- Co-authored-by: Dawid Kaledkowski <dawid.kaledkowski@gmail.com> Co-authored-by: Marcin <133694481+m7pr@users.noreply.github.com>
m7pr
reviewed
Jun 13, 2025
# Pull Request
- Changes from `teal_reportable` branch at `{ŧeal.report}`
- Remove old logic that was defusing the argument
Signed-off-by: Marcin <133694481+m7pr@users.noreply.github.com>
m7pr
reviewed
Jun 18, 2025
Comment on lines
+293
to
+294
| #' @param keep_output (`character`) optional, names of the outputs to keep. | ||
| #' Default is `NULL` which won't keep any outputs. |
There was a problem hiding this comment.
Not needed since we have teal.reporter::eval_code,teal_report-method``
Suggested change
| #' @param keep_output (`character`) optional, names of the outputs to keep. | |
| #' Default is `NULL` which won't keep any outputs. |
There was a problem hiding this comment.
Are we sure it's not needed to pass onto the eval_code inside the decorator?
Merging this to a feature branch. The rest can be dona as normal issues. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Fixes:
Built on top of:
teal.reporterCards teal#1499 (will be closed once this PR is stable)Companion PRs:
{teal}module returns ateal_reportobject that extends fromteal_datateal#1541{teal}module returns ateal_reportobject that extends fromteal_datateal.code#255{teal}module returns ateal_reportobject that extends fromteal_datateal.data#370{teal}module returns ateal_reportobject that extends fromteal_datateal.reporter#331{teal}module returns ateal_reportobject that extends fromteal_data#884Changes description
teal_reportobject on every module