Skip to content

Introducing spiderplot/swimlane/waterfall modules #879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 95 commits into
base: main
Choose a base branch
from

Conversation

gogonzo
Copy link
Contributor

@gogonzo gogonzo commented May 16, 2025

We need to prepare this PR for main, here is what we need to do:

  • We need to remove unnecessary changes made for early stages of POC. For example teal::ui_brush_filter
  • Make a decision about swimlanely, waterfally, spiderplotly. Only tm_ function should be exported. Comment about moving them to different package is a long term solution, at this moment we can unexport them and not implement show-r-code there (nor a reporter)
  • Unlinke other modules, swimlane/waterfall/spiderplot don't have data_extract but I think it is fine at this moment as we are researching a new way. We can merge these new modules to main and give them space to improve

@gogonzo gogonzo added the core label May 16, 2025
Copy link
Contributor

github-actions bot commented May 16, 2025

Unit Tests Summary

  1 files  22 suites   2s ⏱️
152 tests 29 ✅ 123 💤 0 ❌
190 runs  67 ✅ 123 💤 0 ❌

Results for commit 723c084.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented May 16, 2025

Unit Test Performance Difference

Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
examples 👶 $+0.01$ example_dot_color_palette_discrete.Rd
examples 👶 $+0.02$ example_dot_make_reactable_columns_call.Rd
examples 👶 $+0.01$ example_dot_plotly_selected_filter_children.Rd
examples 👶 $+0.01$ example_tm_g_spiderplot.Rd
examples 👶 $+0.01$ example_tm_g_swimlane.Rd
examples 👶 $+0.01$ example_tm_g_waterfall.Rd
examples 👶 $+0.01$ example_tm_rmarkdown.Rd
examples 👶 $+0.01$ example_tm_t_reactables.Rd

Results for commit 5be4599

♻️ This comment has been updated with latest results.

Copy link
Contributor

badge

Code Coverage Summary

Filename                      Stmts    Miss  Cover    Missing
--------------------------  -------  ------  -------  ---------------------------------------
R/module_colur_picker.R          86      86  0.00%    4-128
R/plotly_with_settings.R          5       5  0.00%    2-9
R/tm_a_pca.R                    888     888  0.00%    139-1160
R/tm_a_regression.R             776     776  0.00%    178-1059
R/tm_data_table.R               226     226  0.00%    100-382
R/tm_file_viewer.R              173     173  0.00%    47-255
R/tm_front_page.R               144     133  7.64%    77-247
R/tm_g_association.R            347     347  0.00%    159-581
R/tm_g_bivariate.R              699     435  37.77%   331-827, 868, 979, 996, 1014, 1025-1047
R/tm_g_distribution.R          1118    1118  0.00%    156-1421
R/tm_g_response.R               370     370  0.00%    177-626
R/tm_g_scatterplot.R            716     716  0.00%    260-1078
R/tm_g_scatterplotmatrix.R      297     278  6.40%    198-532, 593, 607
R/tm_g_spiderplot.R             207     207  0.00%    102-359
R/tm_g_swimlane.R               248     248  0.00%    92-391
R/tm_g_waterfall.R              172     172  0.00%    79-291
R/tm_markdown.R                  38      38  0.00%    31-83
R/tm_missing_data.R            1119    1119  0.00%    124-1420
R/tm_outliers.R                1042    1042  0.00%    163-1356
R/tm_t_crosstable.R             262     262  0.00%    163-473
R/tm_t_reactable.R              241     241  0.00%    15-308
R/tm_variable_browser.R         805     800  0.62%    89-1046, 1084-1267
R/utils.R                       297     281  5.39%    39-224, 254-290, 302-311, 316, 330-561
R/zzz.R                           2       2  0.00%    2-3
TOTAL                         10278    9963  3.06%

Diff against main

Filename                    Stmts    Miss  Cover
------------------------  -------  ------  --------
R/module_colur_picker.R       +86     +86  +100.00%
R/plotly_with_settings.R       +5      +5  +100.00%
R/tm_a_pca.R                   -1      -1  +100.00%
R/tm_a_regression.R            +1      +1  +100.00%
R/tm_data_table.R             +25     +25  +100.00%
R/tm_file_viewer.R             +1      +1  +100.00%
R/tm_g_association.R           +1      +1  +100.00%
R/tm_g_bivariate.R             +1      +1  -0.05%
R/tm_g_distribution.R          +1      +1  +100.00%
R/tm_g_response.R              +1      +1  +100.00%
R/tm_g_scatterplot.R          -18     -18  +100.00%
R/tm_g_spiderplot.R          +207    +207  +100.00%
R/tm_g_swimlane.R            +248    +248  +100.00%
R/tm_g_waterfall.R           +172    +172  +100.00%
R/tm_markdown.R               +38     +38  +100.00%
R/tm_outliers.R                -3      -3  +100.00%
R/tm_t_crosstable.R            -2      -2  +100.00%
R/tm_t_reactable.R           +241    +241  +100.00%
R/utils.R                    +146    +146  -5.21%
TOTAL                       +1150   +1150  -0.39%

Results for commit: 723c084

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@gogonzo gogonzo marked this pull request as draft May 16, 2025 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants