pre-release tm_g_response document update
#666
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
averissimo
force-pushed
the
tm_g_response@pre-release@main
branch
from
db75f8c to
ffeec54
Compare
* pre-release@main: pre-release: Typo with missing a full stop (#671)
vedhav
approved these changes
Feb 26, 2024
Contributor
vedhav
left a comment
vedhav
left a comment
There was a problem hiding this comment.
Just a couple of minor comments from me. Other than that LGTM.
I see that the vignettes do not have the author as "NEST CoreDev". Out of scope for this PR, I'll send another small PR for this.
Co-authored-by: Vedha Viyash <49812166+vedhav@users.noreply.github.com> Signed-off-by: André Veríssimo <211358+averissimo@users.noreply.github.com>
m7pr
reviewed
Feb 26, 2024
Contributor
|
@averissimo I think you are good merging this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #624
blocked by #651