Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepare new release to CRAN #31

Closed
4 of 5 tasks
clarkliming opened this issue May 10, 2023 · 1 comment · Fixed by #32
Closed
4 of 5 tasks

prepare new release to CRAN #31

clarkliming opened this issue May 10, 2023 · 1 comment · Fixed by #32

Comments

@clarkliming
Copy link
Collaborator

clarkliming commented May 10, 2023

fix the following notes

  • Please always write package names, software names and API (application
    programming interface) names in single quotes in title and description.
    e.g: --> 'SAS'

  • Please note that package names are case sensitive.

  • Please omit the redundatn "in R" in your title and in the first sentence
    of your description text.

  • Please add \value to .Rd files regarding exported methods and explain
    the functions results in the documentation. Please write about the
    structure of the output (class) and also what the output means. (If a
    function does not return a value, please document that too, e.g.
    \value{No return value, called for side effects} or similar)
    Missing Rd-tags:
    get_sas_cfg.Rd: \value
    get_sas_session.Rd: \value
    install_saspy.Rd: \value
    sas_session_ssh.Rd: \value
    sascfg.Rd: \value

  • Please do not install packages in your functions, examples or vignette.
    This can make the functions,examples and cran-check very slow.

other examples:
https://github.com/r-spatial/rgee/blob/785034fd0f2bd8a8ef7e7b56570d673014473c11/R/ee_install.R#L4

@clarkliming
Copy link
Collaborator Author

for the issue of "please do not install packages in your functions" I think we could, put these code in text format? or we insist on using that function?

clarkliming added a commit that referenced this issue May 22, 2023
close #31 
update for cran release

---------

Co-authored-by: 27856297+dependabot-preview[bot]@users.noreply.github.com <27856297+dependabot-preview[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant