Skip to content

Conversation

@Melkiades
Copy link
Contributor

Fixes #835

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2024

badge

Code Coverage Summary

Filename                     Stmts    Miss  Cover    Missing
-------------------------  -------  ------  -------  -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
R/00tabletrees.R               746      62  91.69%   21, 102, 105, 412, 496-497, 500, 656, 757, 850-851, 952, 954-955, 978-981, 1003, 1115-1118, 1213-1218, 1366, 1463-1466, 1530-1533, 1569-1572, 1578-1583, 1633, 1640, 1740, 1856, 1870, 1873-1876, 1879-1882, 1910, 1941-1942
R/as_html.R                    161      25  84.47%   5-10, 73, 130-135, 140-145, 160-164, 252
R/colby_constructors.R         560      20  96.43%   71, 123, 181-184, 244-247, 386, 403, 1209, 1301, 1463, 1501, 1523, 1547, 1568, 1722
R/compare_rtables.R             83      17  79.52%   92-95, 98-101, 114-117, 136, 156-157, 188, 193
R/format_rcell.R                12       0  100.00%
R/indent.R                      13       2  84.62%   39-40
R/index_footnotes.R             66       0  100.00%
R/make_split_fun.R             119      23  80.67%   22-25, 51-54, 57-60, 115, 119, 279, 282-285, 290-293, 312, 411
R/make_subset_expr.R           136      14  89.71%   34-48, 126-133, 168, 250, 266, 274
R/simple_analysis.R              5       1  80.00%   55
R/split_funs.R                 505      66  86.93%   143, 148, 154-159, 164, 181-185, 365-370, 387-392, 473, 525, 543-546, 563, 630, 640-641, 643, 657, 701, 726, 902, 909, 935-938, 949-950, 952, 954, 1124-1126, 1140-1144, 1208-1211, 1274-1277
R/summary.R                    215      24  88.84%   38, 84, 191, 199, 269-274, 285-286, 305-306, 416, 463-479, 514, 547
R/tree_accessors.R             946     102  89.22%   109, 251, 269, 292, 330, 344, 360, 465, 492-493, 774-779, 907, 925, 949, 999, 1054-1055, 1094, 1127, 1163-1167, 1223, 1298-1302, 1320-1330, 1399, 1504-1507, 1532, 1552-1553, 1562, 1603, 1621-1625, 1646-1650, 1729, 1771, 1875, 1979, 1992, 2005, 2019, 2027, 2036-2040, 2382, 2740, 2853, 2886-2908, 2997-3004, 3159, 3232-3237, 3445-3446, 3453, 3456-3459, 3463, 3510, 3570, 3595-3619
R/tt_afun_utils.R              411      32  92.21%   50, 164, 171, 181-194, 260, 271-272, 503, 511-514, 596-600, 621, 636-638
R/tt_compare_tables.R           70       4  94.29%   56, 178, 257, 261
R/tt_compatibility.R           510      56  89.02%   18, 141-142, 190, 195, 329-330, 334-337, 343, 347, 395, 517, 565, 598, 618, 651-654, 697, 714-718, 805, 833-836, 845, 908, 916, 927-930, 1040, 1047, 1076-1090, 1121-1122
R/tt_dotabulation.R           1125      96  91.47%   54, 252, 257, 259, 310, 334, 338-341, 373-376, 399, 434-437, 465-468, 564, 703-707, 757, 761, 790-793, 803, 823-827, 834-837, 1098, 1102, 1133, 1244-1247, 1452-1460, 1601, 1685-1694, 1774-1777, 1788, 1793, 1798-1799, 1801, 1812, 1817, 1840, 1934-1953
R/tt_export.R                  513      31  93.96%   44, 180-184, 232-235, 287-290, 435, 441, 473, 527, 818, 827, 852-856, 1023-1026, 1029, 1060, 1066
R/tt_from_df.R                  15       0  100.00%
R/tt_paginate.R                440      37  91.59%   45, 70, 107-115, 396, 518-521, 541-545, 694-697, 747-754, 823, 826, 836, 843, 846
R/tt_pos_and_access.R          571      43  92.47%   77, 79-81, 106, 165, 211-215, 260, 513, 515, 523, 529, 543, 553-556, 738, 749-753, 758-761, 788, 841-842, 854, 1020-1021, 1079-1107, 1387, 1464
R/tt_showmethods.R             144      21  85.42%   60, 97-120, 183, 209, 218, 226, 229-233, 326-327
R/tt_sort.R                     98       5  94.90%   261-264, 272
R/tt_toString.R                387      27  93.02%   119, 323-326, 332, 347, 357, 364, 367, 373-383, 471, 536, 542, 776-802
R/utils.R                       29       0  100.00%
R/validate_table_struct.R       84      10  88.10%   79-83, 92-93, 140, 150-151
R/Viewer.R                      61       9  85.25%   46, 50, 60-64, 84, 118
TOTAL                         8025     727  90.94%

Diff against main

Filename               Stmts    Miss  Cover
-------------------  -------  ------  -------
R/00tabletrees.R          +1       0  +0.01%
R/tt_dotabulation.R       +1       0  +0.01%
TOTAL                     +2       0  +0.00%

Results for commit: 774fb13

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2024

Unit Test Performance Difference

Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
Printing tables 👶 $+0.26$ section_div_works_when_analyzing_multiple_variables

Results for commit 02b0ac2

♻️ This comment has been updated with latest results.

Melkiades and others added 4 commits March 6, 2024 19:38
Merge branch '835_fix_section_div_analysis_multivar@main' of github.com:Roche/rtables into 835_fix_section_div_analysis_multivar@main

# Conflicts:
#	tests/testthat/test-printing.R
@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2024

Unit Tests Summary

    1 files     24 suites   1m 33s ⏱️
  203 tests   203 ✅ 0 💤 0 ❌
1 533 runs  1 533 ✅ 0 💤 0 ❌

Results for commit 774fb13.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@edelarua edelarua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Working well. Thanks Davide :)

@Melkiades Melkiades merged commit fea3bcf into main Mar 12, 2024
@Melkiades Melkiades deleted the 835_fix_section_div_analysis_multivar@main branch March 12, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

div_section inside analyze call

3 participants