-
Notifications
You must be signed in to change notification settings - Fork 53
hsep propagation fix
#789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Melkiades
merged 5 commits into
main
from
778_propagate_hsep@223_expand_hsep_custom@main
Nov 27, 2023
Merged
hsep propagation fix
#789
Melkiades
merged 5 commits into
main
from
778_propagate_hsep@223_expand_hsep_custom@main
Nov 27, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Code Coverage SummaryDiff against mainResults for commit: 1ecc309 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Contributor
edelarua
approved these changes
Nov 24, 2023
Contributor
edelarua
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!! Just one minor suggestion from me. Everything is working great! :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to merge after insightsengineering/formatters#228
Fixes #778