-
Notifications
You must be signed in to change notification settings - Fork 53
1047 intermediate guide #1048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1047 intermediate guide #1048
Conversation
Unit Tests Summary 1 files 28 suites 1m 51s ⏱️ Results for commit 733ad2b. ♻️ This comment has been updated with latest results. |
Code Coverage SummaryDiff against mainResults for commit: 733ad2b Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Unit Test Performance Difference
Additional test case details
Results for commit e1e1678 ♻️ This comment has been updated with latest results. |
|
@shajoezhu looks like this is good to go. Also, why is the style check "failing" on the commit that the style job pushed itself. It looks like its viewing the skip instruction as a fail....that seems like an issue |
|
@shajoezhu @Melkiades gentle ping on this |
shajoezhu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! thanks a lot @gmbecker
Signed-off-by: Joe Zhu <joe.zhu@roche.com>
Signed-off-by: Joe Zhu <sha.joe.zhu@gmail.com>
I think I even got the spelling to behave this time... 🤨