Skip to content

Conversation

@vedhav
Copy link
Contributor

@vedhav vedhav commented Mar 31, 2025

Closes #1013

@github-actions
Copy link
Contributor

github-actions bot commented Mar 31, 2025

✅ All contributors have signed the CLA
Posted by the CLA Assistant Lite bot.

@vedhav
Copy link
Contributor Author

vedhav commented Mar 31, 2025

I have read the CLA Document and I hereby sign the CLA

@github-actions
Copy link
Contributor

github-actions bot commented Mar 31, 2025

Unit Tests Summary

    1 files     28 suites   1m 43s ⏱️
  228 tests   228 ✅ 0 💤 0 ❌
1 607 runs  1 607 ✅ 0 💤 0 ❌

Results for commit 1c902c8.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@Melkiades Melkiades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @vedhav! It looks good to me, can you check the errors? Thanks!!

@vedhav vedhav enabled auto-merge (squash) March 31, 2025 08:54
@vedhav vedhav requested a review from Melkiades March 31, 2025 09:04
@github-actions
Copy link
Contributor

badge

Code Coverage Summary

Filename                     Stmts    Miss  Cover    Missing
-------------------------  -------  ------  -------  --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
R/00tabletrees.R               781      63  91.93%   20, 94, 97, 428, 519-520, 523, 681, 785, 877-878, 980, 983, 985-986, 1004-1007, 1027, 1142-1145, 1243-1248, 1404, 1504-1507, 1573-1576, 1612-1615, 1621-1626, 1677, 1684, 1778, 1886, 1899, 1902-1905, 1908-1911, 1938, 1970-1971
R/as_html.R                    172      25  85.47%   5-10, 77, 149-154, 159-164, 179-183, 270
R/colby_constructors.R         597      26  95.64%   81, 134, 197-200, 267-270, 411, 427, 1189, 1277, 1438, 1477, 1488, 1496, 1499, 1524, 1545, 1691, 1914-1917
R/compare_rtables.R             83      17  79.52%   93-96, 99-102, 115-118, 137, 156-157, 188, 193
R/custom_split_funs.R          265      40  84.91%   127, 132, 138-143, 156, 173-177, 353-358, 375-380, 456, 502, 518-521, 537, 599, 609-610, 612, 624, 668, 693
R/default_split_funs.R         286      22  92.31%   271, 334-337, 348-349, 351, 353, 550-554, 618-621, 684-687
R/format_rcell.R                13       0  100.00%
R/indent.R                      13       2  84.62%   40-41
R/index_footnotes.R             66       0  100.00%
R/make_split_fun.R             138      31  77.54%   22-26, 36-39, 52-55, 58-61, 115, 119, 267, 270-273, 278-281, 295, 366, 375, 377, 379, 430
R/make_subset_expr.R           137      15  89.05%   35, 47-61, 135-142, 178, 267, 271, 280
R/summary.R                    144      38  73.61%   35, 80, 178-220, 269, 315-331, 366, 397
R/tree_accessors.R            1129     142  87.42%   110, 139-140, 264, 284, 310, 333, 363, 381, 400-404, 426, 448-451, 566, 593-594, 880-886, 1030, 1049, 1075, 1127, 1184-1185, 1222, 1257, 1295-1300, 1359, 1433-1437, 1455-1464, 1542, 1662-1665, 1690, 1712-1713, 1723, 1774, 1795-1800, 1821-1826, 1837, 1911, 1952, 2051, 2158, 2171, 2185, 2201, 2210, 2220-2224, 2274-2279, 2482, 2492-2495, 2505, 2530-2533, 2540, 2542-2545, 2667, 2701-2702, 2759, 3064, 3425, 3541, 3575-3600, 3691-3699, 3852, 3926-3932, 4107, 4151-4152, 4159, 4162-4165, 4169, 4219, 4280, 4305-4329, 4358
R/tt_afun_utils.R              417      33  92.09%   57, 178, 185, 194-208, 276, 284-285, 503, 511-514, 596-600, 620, 634-636
R/tt_as_df.R                   398      23  94.22%   93-96, 104, 142, 216-219, 361, 380, 450, 469-472, 481, 586, 592, 624, 642, 694
R/tt_compare_tables.R           70       4  94.29%   51, 174, 246, 250
R/tt_compatibility.R           570      70  87.72%   19, 142-143, 186, 191, 319-320, 324-327, 333, 337, 521, 575-578, 615-617, 655, 688, 708, 728-731, 741-744, 789, 806-810, 816-819, 893, 920-923, 932, 994, 1002, 1013-1016, 1127, 1134, 1162-1176, 1207-1208
R/tt_dotabulation.R           1174      95  91.91%   60, 255, 260, 262, 311, 336, 340-343, 376-379, 402, 435-438, 466-469, 567, 709-713, 763, 767, 795-798, 808, 828-832, 839-842, 1106, 1110, 1141, 1244-1247, 1459-1467, 1731-1740, 1822-1825, 1836, 1841, 1846-1847, 1849, 1860, 1865, 1888, 1974-1993
R/tt_export.R                   13       1  92.31%   45
R/tt_from_df.R                  15       0  100.00%
R/tt_paginate.R                513      37  92.79%   74, 122-131, 441, 576-579, 600-604, 749-752, 803-810, 887, 890, 908, 915, 918
R/tt_pos_and_access.R          593      41  93.09%   76, 80, 105, 166, 212-216, 258, 531, 533, 541, 547, 561, 571-574, 760, 763, 771-775, 780-783, 810, 863-864, 875, 1037-1038, 1106-1122, 1392, 1467
R/tt_showmethods.R             162      21  87.04%   56, 91-113, 223, 249, 258, 263, 266-270, 359-360
R/tt_sort.R                    101       5  95.05%   245-248, 256
R/tt_toString.R                436      24  94.50%   126, 350, 372, 385, 395, 401, 404, 410-420, 513, 614, 821-846
R/utils.R                       34       7  79.41%   56, 169-174
R/validate_table_struct.R       84      10  88.10%   80-84, 93-94, 140, 149-150
R/Viewer.R                      61       9  85.25%   46, 50, 60-64, 84, 118
TOTAL                         8465     801  90.54%

Diff against main

Filename       Stmts    Miss  Cover
-----------  -------  ------  -------
R/as_html.R       +5       0  +0.44%
TOTAL             +5       0  +0.01%

Results for commit: 1c902c8

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

@Melkiades Melkiades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Thanks Vedha! Could you add NEWS entry?

@vedhav vedhav merged commit aad3158 into main Mar 31, 2025
29 checks passed
@vedhav vedhav deleted the 1013-fix-borders@main branch March 31, 2025 13:19
@github-actions github-actions bot locked and limited conversation to collaborators Mar 31, 2025
@vedhav
Copy link
Contributor Author

vedhav commented Mar 31, 2025

Ah! there was auto-merge in place. I think it's alright without NEWS as it was the previous state.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When using bslib/Bootstrap 5 the generated rtables does not have borders

3 participants