-
Notifications
You must be signed in to change notification settings - Fork 53
add support for optional .alt_df_full parameter for a/cfuns #1006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Unit Tests Summary 1 files 28 suites 1m 42s ⏱️ Results for commit 8ee7213. ♻️ This comment has been updated with latest results. |
Unit Test Performance DifferenceAdditional test case details
Results for commit a05df08 ♻️ This comment has been updated with latest results. |
Code Coverage SummaryDiff against mainResults for commit: 8ee7213 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
|
@shajoezhu this is the same silly spellcheck error that always happens with Daniel's name, no real failures |
|
hi @gmbecker , is this PR ready for review? can you please raise a PR downstream in tern and scda.test please, see if we have breaking changes. I will look into chevron and autoslider thank you acutally, should be simpler to check https://github.com/insightsengineering/rtables/actions/runs/13827630290 now |
shajoezhu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @gmbecker , i was wondering if you could add explicit test case for using alt_df_full as an argument. thank you
shajoezhu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! thanks @gmbecker
Melkiades
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also for me it is good to go!! Thanks
closes #999. contains documentation updates and tests fyi @iaugusty