Skip to content

add rADQLQC #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 34 commits into from
Dec 8, 2022
Merged

add rADQLQC #225

merged 34 commits into from
Dec 8, 2022

Conversation

sob2021
Copy link
Contributor

@sob2021 sob2021 commented Nov 28, 2022

Pull Request

Adding rADQLQC.
Need package rgdsr

@sob2021 sob2021 requested a review from shajoezhu November 28, 2022 10:02
@sob2021 sob2021 marked this pull request as draft November 28, 2022 10:02
@shajoezhu shajoezhu added the sme label Nov 28, 2022
shajoezhu
shajoezhu reviewed Nov 28, 2022
View reviewed changes
shajoezhu
shajoezhu reviewed Nov 28, 2022
View reviewed changes
shajoezhu
shajoezhu reviewed Nov 28, 2022
View reviewed changes
shajoezhu
shajoezhu reviewed Nov 28, 2022
View reviewed changes
shajoezhu
shajoezhu requested changes Nov 28, 2022
View reviewed changes
Copy link
Contributor

@shajoezhu shajoezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sob2021 , many thanks for your changes, can we please remove the useage of rgdsr, some of the variables names, we can just hard-coded.

for that dataset I think we can save dataframe and load it. Thanks a lot!

@shajoezhu shajoezhu linked an issue Nov 28, 2022 that may be closed by this pull request
Ad additional params to ADQLQC #28
Closed
@shajoezhu shajoezhu self-assigned this Nov 28, 2022
@shajoezhu
Copy link
Contributor

Thanks a lot @sob2021 for working on these issues, once the code is ready, you can run the code in the vignete/build_cached_data to compile the data, git add them and commit as well. Thanks a lot

@sob2021
Copy link
Contributor Author

sob2021 commented Dec 6, 2022

Hi @shajoezhu
I've made all the updates as discussed.

Thank you.

shajoezhu
shajoezhu reviewed Dec 6, 2022
View reviewed changes
@shajoezhu shajoezhu marked this pull request as ready for review December 6, 2022 17:40
@shajoezhu
Copy link
Contributor

Hi @sob2021 , after removing that N parameter, you will need to recompile the dataset.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2022 •
edited
Loading

Unit Tests Summary

  1 files    1 suites   28s ⏱️
23 tests 23 ✔️ 0 💤 0 ❌
56 runs  56 ✔️ 0 💤 0 ❌

Results for commit 64a9f0a.

♻️ This comment has been updated with latest results.

github-actions bot and others added 20 commits December 7, 2022 12:45
@github-actions
[skip actions] Restyle files
5d4dce0
@sob2021
trigger checks
1bbcd23
@sob2021
trigger checks
5810d47
@sob2021
Merge remote-tracking branch 'origin/add_radqlqc' into add_radqlqc
2bc38f7
@sob2021
updates from checks
1976ab9
@sob2021
Merge 1976ab9 into dba7f99
6a0012a
@github-actions
[skip actions] Restyle files
25285d5
@sob2021
trigger checks
528a04d
@sob2021
updates per checks
7f0772f
@github-actions
[skip actions] Roxygen Man Pages Auto Update
6f9bdc2
@sob2021
trigger checks
e038449
@sob2021
updated from R CMD checks
7a18e88
@sob2021
cached data generation
2732e84
@github-actions
[skip actions] Roxygen Man Pages Auto Update
ff60bf5
@sob2021
trigger checks
d65928c
@shajoezhu
update fold name
5073534
@shajoezhu
resolve conflict
02f7559 
Merge branch 'add_radqlqc' of github.com:insightsengineering/random.cdisc.data into add_radqlqc

# Conflicts:
#	vignettes/rebuild_cached_data.Rmd
@shajoezhu
update data
0e86edb
@sob2021
updates per feedback
27621a2
@sob2021
generate cached data
64a9f0a
shajoezhu
shajoezhu approved these changes Dec 8, 2022
View reviewed changes
Copy link
Contributor

@shajoezhu shajoezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

brilliant! Thanks so much @sob2021

@sob2021 sob2021 merged commit 68367fd into main Dec 8, 2022
@sob2021 sob2021 deleted the add_radqlqc branch December 8, 2022 12:50
@Melkiades Melkiades added the enhancement New feature or request label Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shajoezhu shajoezhu shajoezhu approved these changes

Assignees

@shajoezhu shajoezhu

Labels
enhancement New feature or request sme
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ad additional params to ADQLQC
3 participants
@sob2021 @shajoezhu @Melkiades