Skip to content

Update adpp with PKARMCD variable. #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 29, 2022
Merged

Update adpp with PKARMCD variable. #163

merged 7 commits into from
Jun 29, 2022

Conversation

ayogasekaram
Copy link
Contributor

Pull Request

Adding PKARMCD variable (results in 10 different cohorts for TLG plots).

Closes #156

@github-actions
Copy link
Contributor

github-actions bot commented Jun 28, 2022 •
edited
Loading

Code Coverage Summary

Filename         Stmts    Miss  Cover    Missing
-------------  -------  ------  -------  --------------------------------------------------------------------------------------
R/radab.R           80      80  0.00%    34-134
R/radae.R          173       3  98.27%   82, 101, 143
R/radaette.R       211       4  98.10%   52, 73, 79, 243
R/radcm.R          137      27  80.29%   53, 87, 158-184
R/raddv.R           91       3  96.70%   41, 56, 140
R/radeg.R          269       1  99.63%   185
R/radex.R          187       1  99.47%   225
R/radhy.R          136       1  99.26%   197
R/radlb.R          253       1  99.60%   221
R/radmh.R           90       2  97.78%   48, 87
R/radpc.R           60       1  98.33%   100
R/radpp.R           80       1  98.75%   141
R/radqs.R          107       1  99.07%   132
R/radrs.R          121       3  97.52%   49, 56, 156
R/radsaftte.R        1       1  0.00%    17
R/radsl.R          164       1  99.39%   233
R/radsub.R         142       1  99.30%   159
R/radtr.R          127       0  100.00%
R/radtte.R         124       4  96.77%   53, 73, 85, 128
R/radvs.R          160       1  99.38%   174
R/utils.R          154      59  61.69%   9-12, 56-59, 111-112, 117-118, 155-156, 214, 264, 266, 295-301, 305, 338-408, 466, 470
TOTAL             2867     196  93.16%

Results for commit: 9def641

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

github-actions bot commented Jun 28, 2022 •
edited
Loading

Unit Tests Summary

  1 files    1 suites   24s ⏱️
23 tests 23 ✔️ 0 💤 0 ❌
56 runs  56 ✔️ 0 💤 0 ❌

Results for commit c3cebb6.

♻️ This comment has been updated with latest results.

shajoezhu
shajoezhu reviewed Jun 28, 2022
View reviewed changes
@ayogasekaram
Copy link
Contributor Author

I will wait to pull the "regimen" change to adpp after it's been merged and push to this branch again.
Thanks!

@shajoezhu shajoezhu self-assigned this Jun 29, 2022
shajoezhu
shajoezhu approved these changes Jun 29, 2022
View reviewed changes
Copy link
Contributor

@shajoezhu shajoezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Thanks @ayogasekaram

@shajoezhu shajoezhu added the sme label Jun 29, 2022
@shajoezhu
Copy link
Contributor

Hi @ayogasekaram , can you please merge from main, and recompile the data please. Thanks!

@ayogasekaram
Resolving conflicts with regimen change.
44ff71a 
Merge branch 'main' of github.com:insightsengineering/random.cdisc.data into 156_add_pkarmcd_adpp@main

# Conflicts:
#	NEWS.md
#	data/cadpp.RData
#	inst/metadata/ADPP.yml
@ayogasekaram
Updates to versioning
b33bacb
@ayogasekaram
Merge branch 'main' of github.com:insightsengineering/random.cdisc.da…
3b095a2 
…ta into 156_add_pkarmcd_adpp@main

Updating branch to incorporate regimen changes.
@ayogasekaram
Recompiled ADPP data with regimen and PKARMCD.
58e35f6
@shajoezhu
Copy link
Contributor

lgtm! Thanks @ayogasekaram , could you recompile the doc please

roxygen2::roxygenize('.', roclets = c('rd', 'collate', 'namespace'))

@ayogasekaram ayogasekaram merged commit 38f477c into main Jun 29, 2022
@ayogasekaram ayogasekaram deleted the 156_add_pkarmcd_adpp@main branch June 29, 2022 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shajoezhu shajoezhu shajoezhu approved these changes

Assignees

@shajoezhu shajoezhu

Labels
sme
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ADPP : create 6 cohorts
2 participants
@ayogasekaram @shajoezhu