Skip to content

Update authors #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 19, 2022
Merged

Update authors #144

merged 6 commits into from
May 19, 2022

Conversation

pawelru
Copy link
Contributor

@pawelru pawelru commented May 11, 2022

@github-actions
Copy link
Contributor

github-actions bot commented May 11, 2022

Code Coverage Summary

Filename         Stmts    Miss  Cover    Missing
-------------  -------  ------  -------  --------------------------------------------------------------------------------------
R/radae.R          173       3  98.27%   82, 101, 143
R/radaette.R       211       4  98.10%   52, 73, 79, 243
R/radcm.R          137      27  80.29%   53, 87, 158-184
R/raddv.R           91       3  96.70%   41, 56, 140
R/radeg.R          269       1  99.63%   185
R/radex.R          187       1  99.47%   225
R/radhy.R          136       1  99.26%   197
R/radlb.R          253       1  99.60%   221
R/radmh.R           90       2  97.78%   48, 87
R/radpc.R           60       1  98.33%   100
R/radpp.R           70       1  98.57%   123
R/radqs.R          107       1  99.07%   132
R/radrs.R          121       3  97.52%   49, 56, 156
R/radsaftte.R        1       1  0.00%    17
R/radsl.R          164       2  98.78%   48, 233
R/radsub.R         142       1  99.30%   159
R/radtr.R          127       0  100.00%
R/radtte.R         124       4  96.77%   53, 73, 85, 128
R/radvs.R          160       1  99.38%   174
R/utils.R          154      59  61.69%   9-12, 56-59, 111-112, 117-118, 155-156, 214, 264, 266, 295-301, 305, 338-408, 466, 470
TOTAL             2777     117  95.79%

Results for commit: c215b29

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

github-actions bot commented May 11, 2022

Unit Tests Summary

  1 files    1 suites   20s ⏱️
22 tests 22 ✔️ 0 💤 0
55 runs  55 ✔️ 0 💤 0

Results for commit dbc92a7.

♻️ This comment has been updated with latest results.

@@ -4,16 +4,12 @@ Title: Create Random SDTM and ADAM Datasets
Version: 0.3.13.9001
Date: 2021-10-13
Authors@R: c(
person("NEST", , , "basel.nestcicd@roche.com", role = c("aut", "cre")),
person("Adrian", "Waddell", , "adrian.waddell@roche.com", role = "aut"),
Copy link
Contributor

@npaszty npaszty May 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pawelru
pretty sure adrian & heng wrote the first version. would encourage to reach out to him on the author list.
i dont know extent of contribution so what if one of these authors did one PR, does that constitute authorship?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK - I trust your judgment here. It's funny but he's author of ~3% of lines of code and I cannot spot him anywhere at the top of commits / lines added statistics link link. Even in internal GH repo.
Nevertheless, I added Adrian back. And I will reach out to him.
Yes it does account authorship of lines of code as of current state + historical commits data. The detailed criteria is in the linked issue description.

@pawelru pawelru merged commit c4ea016 into main May 19, 2022
@pawelru pawelru deleted the update_authors branch May 19, 2022 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants