-
-
Notifications
You must be signed in to change notification settings - Fork 10
Update authors #144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update authors #144
Conversation
Code Coverage Summary
Results for commit: c215b29 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
@@ -4,16 +4,12 @@ Title: Create Random SDTM and ADAM Datasets | |||
Version: 0.3.13.9001 | |||
Date: 2021-10-13 | |||
Authors@R: c( | |||
person("NEST", , , "basel.nestcicd@roche.com", role = c("aut", "cre")), | |||
person("Adrian", "Waddell", , "adrian.waddell@roche.com", role = "aut"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pawelru
pretty sure adrian & heng wrote the first version. would encourage to reach out to him on the author list.
i dont know extent of contribution so what if one of these authors did one PR, does that constitute authorship?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK - I trust your judgment here. It's funny but he's author of ~3% of lines of code and I cannot spot him anywhere at the top of commits / lines added statistics link link. Even in internal GH repo.
Nevertheless, I added Adrian back. And I will reach out to him.
Yes it does account authorship of lines of code as of current state + historical commits data. The detailed criteria is in the linked issue description.
closes https://github.com/insightsengineering/coredev-tasks/issues/234