Skip to content

98 add adcm variables@main #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 2, 2022
Merged

98 add adcm variables@main #108

merged 7 commits into from
Mar 2, 2022

Conversation

6iris6
Copy link
Contributor

@6iris6 6iris6 commented Feb 25, 2022

Pull Request

Fixes #nnn

@6iris6 6iris6 requested a review from a team as a code owner February 25, 2022 00:39
@shajoezhu shajoezhu requested a review from a team February 25, 2022 00:40
@github-actions
Copy link
Contributor

github-actions bot commented Feb 25, 2022 •
edited
Loading

Unit Tests Summary

  1 files    1 suites   15s ⏱️
21 tests 19 ✔️ 0 💤 0 ❌ 2 🔥
40 runs  38 ✔️ 0 💤 0 ❌ 2 🔥

For more details on these errors, see this check.

Results for commit 9b35e1d.

♻️ This comment has been updated with latest results.

@shajoezhu shajoezhu linked an issue Feb 25, 2022 that may be closed by this pull request
add variables CMINDC, CMDOSE, CMTRT, CMDOSU, CMROUTE, CMDOSFRQ to ADCM #98
Closed
shajoezhu
shajoezhu requested changes Feb 25, 2022
View reviewed changes
Copy link
Contributor

@shajoezhu shajoezhu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Iris, thanks for the changes, please run the following steps in your console

  • lintr:::addin_lint() # lintr, checking code lintr
  • styler::style_file("R/radcm.R") # check code style
  • devtools::document(roclets = c('rd', 'collate', 'namespace', 'vignette')) # rebuild documnetation
  • udate news.md

@shajoezhu shajoezhu self-assigned this Feb 25, 2022
@6iris6
Copy link
Contributor Author

6iris6 commented Feb 25, 2022

The first line gives an error:

lintr:::addin_lint()
Error in if (filename$path == "") { : argument is of length zero

@shajoezhu shajoezhu removed the request for review from a team March 1, 2022 06:41
@shajoezhu shajoezhu enabled auto-merge (squash) March 2, 2022 00:10
@shajoezhu shajoezhu self-requested a review March 2, 2022 00:10
@shajoezhu shajoezhu merged commit 382c2b5 into main Mar 2, 2022
shajoezhu
shajoezhu approved these changes Mar 2, 2022
View reviewed changes
Copy link
Contributor

@shajoezhu shajoezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks iris!

@shajoezhu shajoezhu deleted the 98_add_adcm_variables@main branch March 2, 2022 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shajoezhu shajoezhu shajoezhu approved these changes

Assignees

@shajoezhu shajoezhu

Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add variables CMINDC, CMDOSE, CMTRT, CMDOSU, CMROUTE, CMDOSFRQ to ADCM
2 participants
@6iris6 @shajoezhu