Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Move rebuild condition inside shell #267

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Conversation

cicdguy
Copy link
Contributor

@cicdguy cicdguy commented Nov 12, 2024

That way the step condition evaluation that takes place via JavaScript is less complex and less dependent on the type of event.

@cicdguy cicdguy self-assigned this Nov 12, 2024
@cicdguy cicdguy requested a review from a team as a code owner November 12, 2024 11:59
@cicdguy cicdguy requested a review from pawelru November 12, 2024 12:00
Copy link
Contributor

Unit Tests Summary

3 tests   3 ✅  6s ⏱️
3 suites  0 💤
1 files    0 ❌

Results for commit 51c45f8.

Copy link
Contributor

@pawelru pawelru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@cicdguy cicdguy merged commit 511f8d9 into main Nov 12, 2024
26 checks passed
@cicdguy cicdguy deleted the fix/move-rebuild-condition branch November 12, 2024 12:59
@github-actions github-actions bot locked and limited conversation to collaborators Nov 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants