Skip to content

261 truetype pag new #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

gmbecker
Copy link
Collaborator

Adds the concept of font-based width (number of spaces in the font setting) to wrapping and pagination logic. Lays foundation for upcoming PRs in rtables and rlistings repos.

@gmbecker
Copy link
Collaborator Author

The spell check results are purely false-positives from what I can see

Copy link
Contributor

github-actions bot commented Mar 20, 2024

CLA Assistant Lite bot ✅ All contributors have signed the CLA

@Melkiades
Copy link
Contributor

The spell check results are purely false-positives from what I can see

Code should be between ` and truetype should be one (does it have hypen?) the rest may be added to the spelling

df           MatrixPrintForm.Rd:60
listOrNULL   MatrixPrintForm.Rd:62
monospace    export_as_pdf.Rd:119
             nchar_ttype.Rd:19,39
             tostring.Rd:53
truetype     export_as_pdf.Rd:119
             nchar_ttype.Rd:41,44
             tostring.Rd:53
Truetype     wrap_string_ttype.Rd:6,46
unrounded    nchar_ttype.Rd:[26](https://github.com/insightsengineering/formatters/actions/runs/8333697785/job/22815864386?pr=270#step:9:29)

@Melkiades
Copy link
Contributor

CLA Assistant Lite bot: 🎉 Thank you for your contribution! Before this PR can be accepted, we require that you all read and agree to our Contributor License Agreement. You can digitally sign the CLA by posting a comment on this Pull Request in the format shown below. This agreement will apply to this PR as well as all future contributions on this repository.

I have read the CLA Document and I hereby sign the CLA

0 out of 2 committers have signed the CLA.❌ @gmbecker❌ @MelkiadesYou can retrigger this bot by commenting recheck in this Pull Request

@cicdguy @shajoezhu how can we sign the CLA?

@Melkiades
Copy link
Contributor

I have read the CLA Document and I hereby sign the CLA

@Melkiades
Copy link
Contributor

recheck

@Melkiades
Copy link
Contributor

@gmbecker could you also fix the lintr warnings please? ^^
https://github.com/insightsengineering/formatters/actions/runs/8356002418/job/22872204679?pr=270
I think it is only a matter of code style (like extra spacing etc)

Signed-off-by: Davide Garolini <dgarolini@gmail.com>
gmbecker and others added 5 commits May 27, 2024 11:58
Co-authored-by: Davide Garolini <dgarolini@gmail.com>
Signed-off-by: Gabe Becker <gabembecker@gmail.com>
Co-authored-by: Davide Garolini <dgarolini@gmail.com>
Signed-off-by: Gabe Becker <gabembecker@gmail.com>
Co-authored-by: Davide Garolini <dgarolini@gmail.com>
Signed-off-by: Gabe Becker <gabembecker@gmail.com>
Co-authored-by: Davide Garolini <dgarolini@gmail.com>
Signed-off-by: Gabe Becker <gabembecker@gmail.com>
Co-authored-by: Davide Garolini <dgarolini@gmail.com>
Signed-off-by: Gabe Becker <gabembecker@gmail.com>
Copy link
Collaborator Author

@gmbecker gmbecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

github decided some of my responses are part of "a review"...

Melkiades and others added 2 commits May 28, 2024 10:46
Signed-off-by: Davide Garolini <dgarolini@gmail.com>
Co-authored-by: Davide Garolini <dgarolini@gmail.com>
Signed-off-by: Gabe Becker <gabembecker@gmail.com>
@shajoezhu shajoezhu mentioned this pull request May 29, 2024
36 tasks
@shajoezhu
Copy link
Contributor

can we close this one now?

@gmbecker
Copy link
Collaborator Author

@Melkiades if you're satisfied the comments have all been addressed please feel free to close this

@Melkiades Melkiades closed this May 30, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 30, 2024
@github-actions github-actions bot deleted the 261_truetype_pag_new branch September 1, 2024 03:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
sme Tracks changes for the sme board
Projects
None yet
4 participants