Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds min package version #111

Merged
merged 10 commits into from
Sep 12, 2023
Merged

Adds min package version #111

merged 10 commits into from
Sep 12, 2023

Conversation

averissimo
Copy link
Contributor

@averissimo averissimo commented Jul 18, 2023

WIP :: parent issue: insightsengineering/nestdevs-tasks#7

Supersede:

🔴 Checklist for PR Reviewer

  • Tag yourself next to this repo on Specify minimal version dependencies + add action nestdevs-tasks#7
  • Package versions are the same or higher than main
  • Package list is the same
    • Only exception is rmarkdown (may have been removed on Suggests)
  • All packages in Imports, Depends & Suggests are in new section Config/Needs/verdepcheck
  • Added entry to NEWS.md
  • Last scheduled.yaml action was run succesfully (all 4 strategies)
    • important: it's not the last commit, it's the one that runs 4 Scheduled 🕰️ / Dependency actions
  • scheduled.yaml SHOULD NOT have any push on any branches

🔴 What's needed before merging?

This PR depends on some upstream changes that need to be finalized/merged before being ready to review.

Change in code

  • verdepcheck.yml action (see comments)
    • Remove on: push section
    • Change branch to main

PRS

Changes description

  • Adds minimum version for packages DESCRIPTION
  • Adds Config/Need/verdepcheck section in DESCRIPTION
  • Updates verdepcheck action

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

🧪 $Test coverage: 97.57%$

Code Coverage Summary

Filename               Stmts    Miss  Cover    Missing
-------------------  -------  ------  -------  ---------
R/assertions.R            54       0  100.00%
R/co_relevels.R           17       0  100.00%
R/cut_by_group.R          15       0  100.00%
R/explicit_na.R           26       0  100.00%
R/filter.R                73       0  100.00%
R/join_adsub_adsl.R       66       8  87.88%   126-133
R/pivot.R                 73       0  100.00%
R/propagate.R             22       0  100.00%
R/reformat.R              55       0  100.00%
R/render_safe.R           38       1  97.37%   30
R/rules.R                 53       1  98.11%   53
R/unite.R                 31       0  100.00%
R/utils.R                  8       0  100.00%
R/zzz.R                    3       3  0.00%    4-6
TOTAL                    534      13  97.57%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
R/utils.R       -19       0  +100.00%
TOTAL           -19       0  -0.08%

Results for commit: 0c11201

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

Unit Tests Summary

    1 files    13 suites   2s ⏱️
  81 tests   79 ✔️ 2 💤 0
262 runs  259 ✔️ 3 💤 0

Results for commit 66ad847.

♻️ This comment has been updated with latest results.

@donyunardi donyunardi self-assigned this Sep 7, 2023
@donyunardi donyunardi added the core label Sep 8, 2023
@averissimo
Copy link
Contributor Author

averissimo commented Sep 8, 2023

@donyunardi I rebased against main and triggered the scheduled CI again via a commit here.

Until the workflow is in main we cannot trigger it on GitHub web interface (it can be done via GH cli tool: gh workflow run 63498295 --ref verdepcheck_action)

Copy link

@donyunardi donyunardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Triggered verdepcheck "Scheduled" workflow from this branch:
https://github.com/insightsengineering/dunlin/actions/runs/6151592190

Checked all the requirements mentioned.
LGTM.

@averissimo averissimo merged commit 414ea5f into main Sep 12, 2023
26 checks passed
@averissimo averissimo deleted the verdepcheck_action branch September 12, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants