Upstream/upgrade/php7 #12
Conversation
|
Okay, this is everything I am going to commit for "upgrade/php7". I will open pull requests/issues for everything else. |
composer.json
Outdated
| @@ -34,7 +34,7 @@ | |||
| } | |||
| ], | |||
| "require": { | |||
| "php": "~5.4|~7.0", | |||
| "php": ">=7.0", | |||
There was a problem hiding this comment.
i'm not a fan of unbound version constraints as it can lead to bc breaks with newer language versions. maybe we just stick to the constraint that is already defined?
There was a problem hiding this comment.
Sorry, this was actually meant to be the caret "^". However I can keep the tilde "~" if you want?
| if ($startDate && | ||
| date_diff(new DateTime($currentRelease->published_at), new DateTime($startDate))->days <= 0 | ||
| ) { | ||
| if ($startDate && date_diff(new DateTime($currentRelease->published_at), $startDate)->days <= 0) { |
There was a problem hiding this comment.
i'm fine with this startDate change, when this pr gets merged a new major version will be released to indicate bc breaks
There was a problem hiding this comment.
This doesn't change the functionality of the public API, so it keeps within semver specs. I would suggest keeping this package in the major version of 0 for a few more releases, though. Semver describes a major version of 0 to be used for "...initial development. Anything may change at any time. The public API should not be considered stable." what are your thoughts?
src/ChangelogGenerator.php
Outdated
| @@ -217,7 +216,7 @@ private function getTypeFromLabels(array $labels) | |||
| * | |||
| * @return mixed [description] | |||
| */ | |||
| private function getTypeFromLabel($label, $haystack = null) | |||
| private function getTypeFromLabel(string $label, $haystack = null) | |||
There was a problem hiding this comment.
since we iterate haystack this should be declared as array?
More still to come...
PR #11