Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: re-enable support for ESS 1.1 Notifications #266

Merged
merged 3 commits into from
Jun 3, 2022

Conversation

ThisIsMissEm
Copy link
Contributor

@ThisIsMissEm ThisIsMissEm commented May 20, 2022

Due to a bug in @inrupt/solid-client, we had to temporarily disable support for ESS 1.1 notifications as we couldn't correctly retrieve the data required to find the notifications gateway / storage metadata. We've fixed that bug as of @inrupt/solid-client@1.23.1

Checklist

  • All acceptance criteria are met.
  • Relevant documentation, if any, has been written/updated.
  • The changelog has been updated, if applicable.
  • New functions/types have been exported in index.ts, if applicable.
  • New modules (i.e. new .ts files) are listed in the exports field in package.json, if applicable.
  • New modules (i.e. new .ts files) are listed in the typedocOptions.entryPoints field in tsconfig.json, if applicable.
  • Commits in this PR are minimal and have descriptive commit messages.

@ThisIsMissEm ThisIsMissEm requested a review from a team as a code owner May 20, 2022 18:44
@vercel
Copy link

vercel bot commented May 20, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
solid-client-notifications-js ✅ Ready (Inspect) Visit Preview Jun 3, 2022 at 5:04PM (UTC)

@ThisIsMissEm ThisIsMissEm temporarily deployed to ESS PodSpaces May 20, 2022 18:55 Inactive
@ThisIsMissEm ThisIsMissEm temporarily deployed to ESS PodSpaces May 20, 2022 18:55 Inactive
@ThisIsMissEm ThisIsMissEm temporarily deployed to ESS PodSpaces Next May 20, 2022 18:55 Inactive
@ThisIsMissEm ThisIsMissEm temporarily deployed to ESS PodSpaces Next May 20, 2022 18:55 Inactive
@vercel vercel bot temporarily deployed to Preview May 20, 2022 18:55 Inactive
@ThisIsMissEm ThisIsMissEm temporarily deployed to ESS PodSpaces June 3, 2022 14:47 Inactive
@ThisIsMissEm ThisIsMissEm temporarily deployed to ESS PodSpaces June 3, 2022 14:47 Inactive
@ThisIsMissEm ThisIsMissEm temporarily deployed to ESS PodSpaces Next June 3, 2022 14:47 Inactive
@ThisIsMissEm ThisIsMissEm temporarily deployed to ESS PodSpaces Next June 3, 2022 14:47 Inactive
@vercel vercel bot temporarily deployed to Preview June 3, 2022 14:48 Inactive
@ThisIsMissEm ThisIsMissEm temporarily deployed to ESS PodSpaces June 3, 2022 14:48 Inactive
@ThisIsMissEm ThisIsMissEm temporarily deployed to ESS PodSpaces June 3, 2022 14:48 Inactive
@ThisIsMissEm ThisIsMissEm temporarily deployed to ESS PodSpaces Next June 3, 2022 14:48 Inactive
@ThisIsMissEm ThisIsMissEm temporarily deployed to ESS PodSpaces Next June 3, 2022 14:48 Inactive
@vercel vercel bot temporarily deployed to Preview June 3, 2022 14:49 Inactive
@ThisIsMissEm ThisIsMissEm temporarily deployed to ESS PodSpaces June 3, 2022 14:57 Inactive
@ThisIsMissEm ThisIsMissEm temporarily deployed to ESS PodSpaces June 3, 2022 14:57 Inactive
@ThisIsMissEm ThisIsMissEm temporarily deployed to ESS PodSpaces Next June 3, 2022 14:57 Inactive
@ThisIsMissEm ThisIsMissEm temporarily deployed to ESS PodSpaces Next June 3, 2022 14:57 Inactive
@vercel vercel bot temporarily deployed to Preview June 3, 2022 14:58 Inactive
@ThisIsMissEm ThisIsMissEm temporarily deployed to ESS PodSpaces June 3, 2022 15:30 Inactive
@ThisIsMissEm ThisIsMissEm temporarily deployed to ESS PodSpaces Next June 3, 2022 15:30 Inactive
@ThisIsMissEm ThisIsMissEm temporarily deployed to ESS PodSpaces June 3, 2022 15:45 Inactive
@ThisIsMissEm ThisIsMissEm temporarily deployed to ESS PodSpaces June 3, 2022 15:45 Inactive
@ThisIsMissEm ThisIsMissEm temporarily deployed to ESS PodSpaces Next June 3, 2022 15:45 Inactive
@ThisIsMissEm ThisIsMissEm temporarily deployed to ESS PodSpaces Next June 3, 2022 15:45 Inactive
@vercel vercel bot temporarily deployed to Preview June 3, 2022 15:46 Inactive
@ThisIsMissEm ThisIsMissEm temporarily deployed to ESS PodSpaces June 3, 2022 17:04 Inactive
@ThisIsMissEm ThisIsMissEm temporarily deployed to ESS PodSpaces June 3, 2022 17:04 Inactive
@ThisIsMissEm ThisIsMissEm temporarily deployed to ESS PodSpaces Next June 3, 2022 17:04 Inactive
@ThisIsMissEm ThisIsMissEm temporarily deployed to ESS PodSpaces Next June 3, 2022 17:04 Inactive
@vercel vercel bot temporarily deployed to Preview June 3, 2022 17:04 Inactive
@ThisIsMissEm ThisIsMissEm temporarily deployed to ESS PodSpaces June 3, 2022 17:09 Inactive
@ThisIsMissEm ThisIsMissEm temporarily deployed to ESS PodSpaces Next June 3, 2022 17:09 Inactive
@ThisIsMissEm ThisIsMissEm merged commit 95e27c4 into main Jun 3, 2022
@ThisIsMissEm ThisIsMissEm deleted the fix/support-ess-1.1 branch June 3, 2022 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants