-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: re-enable support for ESS 1.1 Notifications #266
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ThisIsMissEm
force-pushed
the
fix/support-ess-1.1
branch
from
May 20, 2022 18:55
9c09b36
to
10f21f0
Compare
ThisIsMissEm
force-pushed
the
fix/support-ess-1.1
branch
from
June 3, 2022 14:48
969c67d
to
c685002
Compare
ThisIsMissEm
force-pushed
the
fix/support-ess-1.1
branch
from
June 3, 2022 14:57
c685002
to
f7902ea
Compare
ThisIsMissEm
force-pushed
the
fix/support-ess-1.1
branch
from
June 3, 2022 15:45
f7902ea
to
3738bff
Compare
ajacksified
approved these changes
Jun 3, 2022
ThisIsMissEm
force-pushed
the
fix/support-ess-1.1
branch
from
June 3, 2022 17:04
3738bff
to
0252275
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a bug in
@inrupt/solid-client
, we had to temporarily disable support for ESS 1.1 notifications as we couldn't correctly retrieve the data required to find the notifications gateway / storage metadata. We've fixed that bug as of@inrupt/solid-client@1.23.1
Checklist
index.ts
, if applicable..ts
files) are listed in theexports
field inpackage.json
, if applicable..ts
files) are listed in thetypedocOptions.entryPoints
field intsconfig.json
, if applicable.