Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: parse messages as json #245

Merged
merged 27 commits into from
May 5, 2022
Merged

Conversation

ThisIsMissEm
Copy link
Contributor

@ThisIsMissEm ThisIsMissEm commented Apr 20, 2022

New feature description

  • Parses the websocket messages as JSON, instead of leaving this to the end-user
  • Correctly documents events emitted from the WebsocketNotification class
  • Switch to getWellKnownSolid from solid-client to work across both ESS 1.1 and ESS 1.2
  • Fix unit tests (migrate from jest-fetch-mock which caused issues for e2e tests)
  • Fix & re-enable e2e browser and node.js tests
  • Drop support for Node.js v12 (end of life)
  • Migrate CI/CD to use new environments (ESS PodSpaces & ESS PodSpaces Next)

Checklist

  • All acceptance criteria are met.
  • Relevant documentation, if any, has been written/updated.
  • The changelog has been updated, if applicable.
  • New functions/types have been exported in index.ts, if applicable. n/a
  • New modules (i.e. new .ts files) are listed in the exports field in package.json, if applicable. n/a
  • New modules (i.e. new .ts files) are listed in the typedocOptions.entryPoints field in tsconfig.json, if applicable. n/a
  • Commits in this PR are minimal and have descriptive commit messages.

@ThisIsMissEm ThisIsMissEm requested a review from a team as a code owner April 20, 2022 00:41
@vercel
Copy link

vercel bot commented Apr 20, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
solid-client-notifications-js ✅ Ready (Inspect) Visit Preview May 4, 2022 at 2:55PM (UTC)

Copy link
Contributor

@kay-kim kay-kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ThisIsMissEm - just left a little comment about the landing page blurbs. You might want to work with @nicolasmondada about how to position the product.

docs/api/source/index.rst Outdated Show resolved Hide resolved
docs/api/source/index.rst Outdated Show resolved Hide resolved
docs/api/source/index.rst Outdated Show resolved Hide resolved
@ThisIsMissEm ThisIsMissEm force-pushed the feature/parse-messages-as-json branch from 7e09988 to 1f8e6aa Compare April 20, 2022 02:41
@ThisIsMissEm ThisIsMissEm temporarily deployed to ESS Production April 20, 2022 02:41 Inactive
@ThisIsMissEm ThisIsMissEm temporarily deployed to ESS Production April 20, 2022 02:41 Inactive
@ThisIsMissEm ThisIsMissEm temporarily deployed to ESS Dev-Next April 20, 2022 02:41 Inactive
@vercel vercel bot temporarily deployed to Preview April 20, 2022 02:42 Inactive
@ThisIsMissEm ThisIsMissEm temporarily deployed to ESS Production April 20, 2022 02:47 Inactive
@ThisIsMissEm ThisIsMissEm temporarily deployed to ESS Production April 20, 2022 02:57 Inactive
@ThisIsMissEm ThisIsMissEm temporarily deployed to ESS Dev-Next April 20, 2022 02:57 Inactive
@ThisIsMissEm ThisIsMissEm temporarily deployed to ESS Production April 20, 2022 02:57 Inactive
@vercel vercel bot temporarily deployed to Preview April 20, 2022 02:58 Inactive
@ThisIsMissEm ThisIsMissEm temporarily deployed to ESS Production April 20, 2022 03:03 Inactive
@ThisIsMissEm ThisIsMissEm temporarily deployed to ESS Production April 20, 2022 03:24 Inactive
@ThisIsMissEm ThisIsMissEm temporarily deployed to ESS Production April 20, 2022 03:24 Inactive
@ThisIsMissEm ThisIsMissEm temporarily deployed to ESS Dev-Next April 20, 2022 03:24 Inactive
@vercel vercel bot temporarily deployed to Preview April 20, 2022 03:25 Inactive
@ThisIsMissEm ThisIsMissEm temporarily deployed to ESS Production April 20, 2022 03:31 Inactive
@ThisIsMissEm ThisIsMissEm temporarily deployed to ESS Production April 20, 2022 03:46 Inactive
@ThisIsMissEm ThisIsMissEm temporarily deployed to ESS Production April 20, 2022 04:16 Inactive
@ThisIsMissEm ThisIsMissEm temporarily deployed to ESS Production April 20, 2022 04:16 Inactive
@ThisIsMissEm ThisIsMissEm temporarily deployed to ESS Dev-Next April 20, 2022 04:16 Inactive
@vercel vercel bot temporarily deployed to Preview April 20, 2022 04:17 Inactive
@ThisIsMissEm ThisIsMissEm temporarily deployed to ESS Production April 20, 2022 04:22 Inactive
@ThisIsMissEm ThisIsMissEm temporarily deployed to ESS PodSpaces Next April 21, 2022 19:52 Inactive
@ThisIsMissEm ThisIsMissEm temporarily deployed to ESS PodSpaces Next April 21, 2022 19:52 Inactive
@vercel vercel bot temporarily deployed to Preview April 21, 2022 19:53 Inactive
E2E_TEST_CLIENT_ID: ${{ secrets.E2E_TEST_CLIENT_ID }}
E2E_TEST_CLIENT_SECRET: ${{ secrets.E2E_TEST_CLIENT_SECRET }}
E2E_TEST_ENVIRONMENT: "ESS Production"
# cd-end-to-end-tests:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was broken for some reason and I couldn't get it working for the life of me. This is probably not important.

@ThisIsMissEm ThisIsMissEm temporarily deployed to ESS PodSpaces Next May 4, 2022 12:18 Inactive
@ThisIsMissEm ThisIsMissEm temporarily deployed to ESS PodSpaces Next May 4, 2022 12:18 Inactive
@vercel vercel bot temporarily deployed to Preview May 4, 2022 12:19 Inactive
e2e/browser/test/e2e.playwright.ts Outdated Show resolved Hide resolved
e2e/node/e2e.test.ts Show resolved Hide resolved
@ThisIsMissEm ThisIsMissEm force-pushed the feature/parse-messages-as-json branch from 874874f to 0c8d60d Compare May 4, 2022 13:47
@ThisIsMissEm ThisIsMissEm temporarily deployed to ESS PodSpaces Next May 4, 2022 13:48 Inactive
@ThisIsMissEm ThisIsMissEm temporarily deployed to ESS PodSpaces Next May 4, 2022 13:48 Inactive
@vercel vercel bot temporarily deployed to Preview May 4, 2022 13:48 Inactive
@ThisIsMissEm ThisIsMissEm temporarily deployed to ESS PodSpaces Next May 4, 2022 13:53 Inactive
@ThisIsMissEm ThisIsMissEm temporarily deployed to ESS PodSpaces Next May 4, 2022 14:54 Inactive
@ThisIsMissEm ThisIsMissEm temporarily deployed to ESS PodSpaces Next May 4, 2022 14:54 Inactive
@vercel vercel bot temporarily deployed to Preview May 4, 2022 14:55 Inactive
@ThisIsMissEm ThisIsMissEm merged commit bf632e9 into main May 5, 2022
@ThisIsMissEm ThisIsMissEm deleted the feature/parse-messages-as-json branch May 5, 2022 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants