chore: fix license header #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThisIsMissEm
force-pushed
the
chore/fix-license-header
branch
from
0567a75
to
0dac1b1
Compare
ThisIsMissEm
commented
Apr 9, 2022
| # FIXME: Remove after switching to playwright | ||
| e2e/browser | ||
| # e2e browser testApp has it's own separate eslint configuration: | ||
| e2e/browser/testApp |
There was a problem hiding this comment.
@NSeydoux we should ideally find a way to not have a separate eslint configuration for the testApp, or maybe use a post-install script to install the dependencies for the testApp such that linting won't fail at that boundary.
There was a problem hiding this comment.
The post-install script seems like a good idea. I'll see how it looks like locally.
ThisIsMissEm
commented
Apr 9, 2022
| // as the root directory for compilation (instead of /src), | ||
| // meaning that files that would otherwise be included in /dist directly | ||
| // (e.g. dist/index.d.ts) will then be built to /dist/src. | ||
| "e2e", |
There was a problem hiding this comment.
I did verify that the build output remained consistent after this change, though someone may wish to double check. The logic here is that as we never include e2e, we don't need to exclude it.
NSeydoux
approved these changes
Apr 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous license header applied here is not consistent with that from ts-template, so this fixes that, whilst also ensuring the e2e tests are covered by eslint, whilst still excluding the testapp which has it's own linting configuration.