Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request well-known as json-ld #166

Merged
merged 7 commits into from
Dec 13, 2021
Merged

Request well-known as json-ld #166

merged 7 commits into from
Dec 13, 2021

Conversation

ajacksified
Copy link
Contributor

This PR fixes #2284.

  • I've added a unit test to test for potential regressions of this bug.
  • The changelog has been updated, if applicable.
  • Commits in this PR are minimal and have descriptive commit messages.

@vercel vercel bot temporarily deployed to Preview November 12, 2021 15:57 Inactive
@vercel vercel bot temporarily deployed to Preview November 12, 2021 16:17 Inactive
NSeydoux
NSeydoux approved these changes Nov 12, 2021
View reviewed changes
Copy link
Contributor

@NSeydoux NSeydoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. You could also consider using getWellKnownSolid from solid-client, but that adds a new dependency.

@ajacksified
Copy link
Contributor Author

Looks good to me. You could also consider using getWellKnownSolid from solid-client, but that adds a new dependency.

Yeah, I figured we'd do the bare minimum change immediately and then refactor to use that later on.

@vercel vercel bot temporarily deployed to Preview November 17, 2021 22:30 Inactive
@vercel vercel bot temporarily deployed to Preview November 17, 2021 22:38 Inactive
@vercel vercel bot temporarily deployed to Preview November 18, 2021 08:18 Inactive
@vercel vercel bot temporarily deployed to Preview November 18, 2021 08:25 Inactive
@NSeydoux
Fix browser environment
23f4f92 
The positional env vars are not provided in the right order.
@vercel vercel bot temporarily deployed to Preview November 18, 2021 09:03 Inactive
@vercel vercel bot temporarily deployed to Preview November 18, 2021 10:15 Inactive
@vercel vercel bot temporarily deployed to Preview November 18, 2021 13:41 Inactive
@vercel vercel bot temporarily deployed to Preview November 18, 2021 13:47 Inactive
@vercel vercel bot temporarily deployed to Preview November 26, 2021 14:48 Inactive
@vercel vercel bot temporarily deployed to Preview December 7, 2021 11:02 Inactive
@vercel vercel bot temporarily deployed to Preview December 13, 2021 13:53 Inactive
@vercel vercel bot temporarily deployed to Preview December 13, 2021 14:05 Inactive
@vercel vercel bot temporarily deployed to Preview December 13, 2021 14:59 Inactive
@ajacksified ajacksified merged commit 76f413c into main Dec 13, 2021
@ajacksified ajacksified deleted the fix/request-json-ld branch December 13, 2021 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NSeydoux NSeydoux NSeydoux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ajacksified @NSeydoux