Fix #2339: getResourcePolicyAll returns unnamed policies
#2370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NSeydoux
had a problem deploying
to
ESS PodSpaces
GitHub Actions
Failure
- Discover policies from access control: This goes toward supporting blank nodes policies, but fails because `getThing` doesn't support blank nodes. - Fix blank nodes ids used for matching - Align option name with getThingAll
NSeydoux
force-pushed
the
fix/SDK-3296/acp-api-blank-nodes
branch
from
039edc7 to
1174009
Compare
NSeydoux
had a problem deploying
to
ESS PodSpaces
GitHub Actions
Failure
NSeydoux
had a problem deploying
to
ESS PodSpaces
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #2339. It relies on #2368 and #2369 , so these should be reviewed first.
With these changes,
getResourcePolicyAllgets a new options argument, which can be set to{ acceptBlankNodes: true }in order for unnamed policies to be included in the result set. The default behavior ofgetResourcePolicyAllis unchanged, because otherwise this would be a breaking change, as the return type of the function would change.