Enforce URL path semantics in containment lookup #2059
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jeswr
approved these changes
Jul 1, 2023
jeswr
suggested changes
Jul 1, 2023
jeswr
reviewed
Jul 3, 2023
jeswr
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When listing contained resources with
getContainedResourcesAll, in addition to usingldp:containsclaims, we apply a filter so that we only return resources that are child resources of the target container from a URL path semantics perspective as well. This means[https://pod.example.org/foo/bar/moo](https://pod.example.org/foo/bar/moo%60) cannot be considered a child resource of[https://pod.example.org/foo/](https://pod.example.org/foo/%60). Resources from a different origin will also be excluded.This prevents malicious Pods from claiming containment across domains, which could lead to incorrect behavior of the clients.