Fix: ignore not found error when fetching ACL so that a new one is initialized #1942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
VirginiaBalseiro
temporarily deployed
to
ESS PodSpaces
GitHub Actions
Inactive
VirginiaBalseiro
temporarily deployed
to
ESS PodSpaces
GitHub Actions
Inactive
VirginiaBalseiro
temporarily deployed
to
ESS PodSpaces
GitHub Actions
Inactive
VirginiaBalseiro
temporarily deployed
to
ESS Dev-Next
GitHub Actions
Inactive
NSeydoux
requested changes
Apr 14, 2023
Contributor
NSeydoux
left a comment
NSeydoux
left a comment
There was a problem hiding this comment.
The code is fine, but I think more context in the comment would be helpful, to be kind to future us :p
src/acp/acp.ts
Outdated
| options | ||
| ); | ||
| } catch (e) { | ||
| // if the above fails, an ACL cannot be found and we proceed. |
Contributor
There was a problem hiding this comment.
I think it would be helpful to expand this comment a bit, to recontextualize why that's a correct behavior, rather than describing what the code does. For instance, remind that both ACL and ACR will be discovered through the same header, and that an additional lookup is required for checking the type of the resource, and that the absence of the resource is only possible in the case of an ACL, because in the ACR system the ACR is always present.
VirginiaBalseiro
temporarily deployed
to
ESS PodSpaces
GitHub Actions
Inactive
VirginiaBalseiro
temporarily deployed
to
ESS PodSpaces
GitHub Actions
Inactive
VirginiaBalseiro
temporarily deployed
to
ESS PodSpaces
GitHub Actions
Inactive
VirginiaBalseiro
temporarily deployed
to
ESS Dev-Next
GitHub Actions
Inactive
VirginiaBalseiro
temporarily deployed
to
ESS PodSpaces
GitHub Actions
Inactive
VirginiaBalseiro
temporarily deployed
to
ESS PodSpaces
GitHub Actions
Inactive
VirginiaBalseiro
temporarily deployed
to
ESS Dev-Next
GitHub Actions
Inactive
VirginiaBalseiro
force-pushed
the
fix/acl-not-found-error
branch
from
6fc6b27 to
1b64b47
Compare
VirginiaBalseiro
temporarily deployed
to
ESS PodSpaces
GitHub Actions
Inactive
VirginiaBalseiro
temporarily deployed
to
ESS PodSpaces
GitHub Actions
Inactive
VirginiaBalseiro
temporarily deployed
to
ESS PodSpaces
GitHub Actions
Inactive
VirginiaBalseiro
temporarily deployed
to
ESS PodSpaces
GitHub Actions
Inactive
VirginiaBalseiro
temporarily deployed
to
ESS Dev-Next
GitHub Actions
Inactive
VirginiaBalseiro
temporarily deployed
to
ESS PodSpaces
GitHub Actions
Inactive
VirginiaBalseiro
temporarily deployed
to
ESS Dev-Next
GitHub Actions
Inactive
NSeydoux
approved these changes
Apr 17, 2023
Contributor
NSeydoux
left a comment
NSeydoux
left a comment
There was a problem hiding this comment.
Can you break down the comment in multiple lines before merging, so that this is roughly aligned with our linting config?
VirginiaBalseiro
force-pushed
the
fix/acl-not-found-error
branch
from
1b64b47 to
a9d4e73
Compare
VirginiaBalseiro
temporarily deployed
to
ESS PodSpaces
GitHub Actions
Inactive
VirginiaBalseiro
temporarily deployed
to
ESS PodSpaces
GitHub Actions
Inactive
VirginiaBalseiro
temporarily deployed
to
ESS Dev-Next
GitHub Actions
Inactive
VirginiaBalseiro
temporarily deployed
to
ESS PodSpaces
GitHub Actions
Inactive
VirginiaBalseiro
temporarily deployed
to
ESS PodSpaces
GitHub Actions
Inactive
VirginiaBalseiro
temporarily deployed
to
ESS PodSpaces
GitHub Actions
Inactive
VirginiaBalseiro
temporarily deployed
to
ESS Dev-Next
GitHub Actions
Inactive
Contributor
Author
Oops, thought I did. Fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1549.
A 404 error was throwing, which was blocking the new ACL from being initialized when one was not found. In this PR, we ignore this error so that the function can resume and the ACL initialization can be handled.
// tests pending work on setting up CSS tests