Skip to content

JCL-373: Address minor compiler warnings #503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
acoburn merged 2 commits into from
Jun 1, 2023
Merged

JCL-373: Address minor compiler warnings #503

acoburn merged 2 commits into from
Jun 1, 2023

Conversation

@acoburn
Copy link
Collaborator

@acoburn acoburn commented May 31, 2023

There are two categories of changes here:

  • For type coersions, we are explicit about cases where those are allowed (@SuppressWarnings("unchecked")) -- in each case, the compiler already catches errors, but the type system isn't quite smart enough to know that the casts are legal
  • Removal of deprecated methods -- some of our code is intentionally using methods that we have marked as deprecated, but in some cases, we simply haven't updated those code paths to use the latest version

@acoburn acoburn requested a review from a team as a code owner May 31, 2023 18:02
edwardsph
edwardsph approved these changes Jun 1, 2023
View reviewed changes
Copy link
Contributor

@edwardsph edwardsph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acoburn acoburn enabled auto-merge (squash) June 1, 2023 09:51
@acoburn acoburn merged commit cac23a1 into main Jun 1, 2023
@acoburn acoburn deleted the JCL-373-minor-compiler-warnings branch June 1, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@edwardsph edwardsph edwardsph approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@acoburn @edwardsph