JCL-335: issue request builder & grant approval calls #422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timea-solid
temporarily deployed
to
ESS PodSpaces
GitHub Actions
Inactive
timea-solid
temporarily deployed
to
ESS PodSpaces
GitHub Actions
Inactive
timea-solid
temporarily deployed
to
ESS PodSpaces
GitHub Actions
Inactive
timea-solid
temporarily deployed
to
ESS PodSpaces
GitHub Actions
Inactive
timea-solid
temporarily deployed
to
ESS PodSpaces
GitHub Actions
Inactive
timea-solid
temporarily deployed
to
ESS PodSpaces
GitHub Actions
Inactive
timea-solid
temporarily deployed
to
ESS PodSpaces
GitHub Actions
Inactive
timea-solid
temporarily deployed
to
ESS PodSpaces
GitHub Actions
Inactive
acoburn
reviewed
Apr 21, 2023
Collaborator
acoburn
left a comment
acoburn
left a comment
There was a problem hiding this comment.
Might be worth discussing this in more detail
| * @param request an AccessRequest | ||
| * @return the next stage of completion containing the resulting credential | ||
| */ | ||
| public CompletionStage<AccessGrant> approveAccessRequest(final AccessRequest request) { |
Collaborator
There was a problem hiding this comment.
I would call this issueAccessGrant
Contributor
Author
There was a problem hiding this comment.
issueAccessRequest name is to specify it is a request and not the actual issue call.
I call it better issueGrantRequest
| /** | ||
| * An Access Grant issue request. | ||
| */ | ||
| public class AccessRequest { |
Collaborator
There was a problem hiding this comment.
I would have this extend or implement an AccessCredential type
| return this.data; | ||
| } | ||
|
|
||
| public AccessRequest(final Map<String, Object> data) { |
Collaborator
There was a problem hiding this comment.
I would make this more structured. A map is too general
Contributor
Author
|
I know we discussed removing the extra class but that would require me to pass Map<String, Object> around. Because of this, I try here to create more architecture. |
Collaborator
|
Superseded by #461 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The names are at the moment taken form the JS library:
We can of course rethink the names.
The issueAccessRequest has a toCompletableFuture().join() now, not sure.