Add Spring example with authentication #1255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
langsamu
reviewed
May 13, 2024
Co-authored-by: Samu Lang <langsamu@users.noreply.github.com>
langsamu
reviewed
May 14, 2024
Contributor
langsamu
left a comment
langsamu
left a comment
There was a problem hiding this comment.
I don't want to waste too much time on this simple demo JS, but I think the current mixing of promise methods and asynchronous keywords is not an improvement.
NSeydoux
approved these changes
May 15, 2024
Contributor
NSeydoux
left a comment
NSeydoux
left a comment
There was a problem hiding this comment.
This overall looks good to me, although I don't have enough Spring experience to have a strong opinion on the idiomacy of the proposed app.
...es/spring-web/src/main/java/com/inrupt/client/examples/spring/web/SecurityConfiguration.java
Show resolved
Hide resolved
examples/spring-web/src/main/java/com/inrupt/client/examples/spring/web/WebApplication.java
Show resolved
Hide resolved
examples/spring-web/src/main/java/com/inrupt/client/examples/spring/web/model/WebId.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds another Spring-based example application. This application does not currently have any CSS styling to speak of, but the Spring API portion uses recommended, idiomatic constructs.